backend-storage: add functional tests

Signed-off-by: Jed Lejosne <jed@redhat.com>

tests/storage/BUILD.bazel

@@ -3,6 +3,7 @@ load("@io_bazel_rules_go//go:def.bzl", "go_library")
 go_library(
     name = "go_default_library",
     srcs = [
+        "backendstorage.go",
         "datavolume.go",
         "events.go",
         "export.go",
@@ -22,9 +23,11 @@ go_library(
     deps = [
         "//pkg/apimachinery/patch:go_default_library",
         "//pkg/certificates/triple/cert:go_default_library",
+        "//pkg/controller:go_default_library",
         "//pkg/host-disk:go_default_library",
         "//pkg/libvmi:go_default_library",
         "//pkg/pointer:go_default_library",
+        "//pkg/storage/backend-storage:go_default_library",
         "//pkg/storage/reservation:go_default_library",
         "//pkg/storage/types:go_default_library",
         "//pkg/virt-config:go_default_library",

tests/storage/backendstorage.go

@@ -0,0 +1,131 @@
+/*
+ * This file is part of the KubeVirt project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ * Copyright 2024 The KubeVirt Contributors
+ *
+ */
+
+package storage
+
+import (
+	"context"
+
+	"kubevirt.io/kubevirt/pkg/controller"
+
+	"kubevirt.io/kubevirt/tests/libnet"
+
+	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/gomega"
+	corev1 "k8s.io/api/core/v1"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	v1 "kubevirt.io/api/core/v1"
+	"kubevirt.io/client-go/kubecli"
+
+	"kubevirt.io/kubevirt/pkg/pointer"
+	backendstorage "kubevirt.io/kubevirt/pkg/storage/backend-storage"
+	"kubevirt.io/kubevirt/tests"
+	"kubevirt.io/kubevirt/tests/framework/kubevirt"
+	"kubevirt.io/kubevirt/tests/libvmifact"
+	"kubevirt.io/kubevirt/tests/util"
+)
+
+var _ = SIGDescribe("[Serial]Backend Storage", Serial, func() {
+	var virtClient kubecli.KubevirtClient
+
+	BeforeEach(func() {
+		virtClient = kubevirt.Client()
+	})
+
+	It("Should use the default storage class when none is specified in the CR", func() {
+		By("Removing the VM state storage class from the CR")
+		kv := util.GetCurrentKv(virtClient)
+		kv.Spec.Configuration.VMStateStorageClass = ""
+		tests.UpdateKubeVirtConfigValueAndWait(kv.Spec.Configuration)
+
+		By("Creating a VMI with persistent TPM")
+		vmi := libvmifact.NewCirros()
+		vmi.Spec.Domain.Devices.TPM = &v1.TPMDevice{Persistent: pointer.P(true)}
+		vmi = tests.RunVMIAndExpectLaunch(vmi, 60)
+
+		By("Expecting the creation of a backend storage PVC with the default storage class")
+		pvc, err := virtClient.CoreV1().PersistentVolumeClaims(vmi.Namespace).Get(context.Background(), backendstorage.PVCForVMI(vmi), metav1.GetOptions{})
+		Expect(err).NotTo(HaveOccurred())
+		Expect(pvc.Spec.StorageClassName).NotTo(BeNil())
+		storageClass, err := virtClient.StorageV1().StorageClasses().Get(context.Background(), *pvc.Spec.StorageClassName, metav1.GetOptions{})
+		Expect(storageClass.Annotations).To(HaveKeyWithValue("storageclass.kubernetes.io/is-default-class", "true"))
+	})
+
+	// TODO: create a RequiresRWXFilesystemStorage decorator to remove the skip?
+	It("Should use RWO when RWX is not supported", func() {
+		var storageClass string
+
+		By("Finding a storage class that only supports filesystem in RWO")
+		sps, err := virtClient.CdiClient().CdiV1beta1().StorageProfiles().List(context.Background(), metav1.ListOptions{})
+		Expect(err).NotTo(HaveOccurred()) // Assumes CDI is present. Should we also add a decorator for that?
+		for _, sp := range sps.Items {
+			fsrwo := false
+			fsrwx := false
+			for _, property := range sp.Status.ClaimPropertySets {
+				if property.VolumeMode == nil || *property.VolumeMode != corev1.PersistentVolumeFilesystem || property.AccessModes == nil {
+					continue
+				}
+				for _, accessMode := range property.AccessModes {
+					switch accessMode {
+					case corev1.ReadWriteMany:
+						fsrwx = true
+					case corev1.ReadWriteOnce:
+						fsrwo = true
+					}
+				}
+			}
+			if fsrwo && !fsrwx && sp.Status.StorageClass != nil {
+				storageClass = *sp.Status.StorageClass
+				break
+			}
+		}
+		if storageClass == "" {
+			Skip("Failed to find a suitable storage class") // See TODO above
+		}
+
+		By("Setting the VM storage class to it")
+		kv := util.GetCurrentKv(virtClient)
+		kv.Spec.Configuration.VMStateStorageClass = storageClass
+		tests.UpdateKubeVirtConfigValueAndWait(kv.Spec.Configuration)
+
+		By("Creating a VMI with persistent TPM")
+		vmi := libvmifact.NewCirros(
+			libnet.WithMasqueradeNetworking()...,
+		)
+		vmi.Spec.Domain.Devices.TPM = &v1.TPMDevice{Persistent: pointer.P(true)}
+		vmi = tests.RunVMIAndExpectLaunch(vmi, 60)
+
+		By("Expecting the creation of a backend storage PVC with the right storage class")
+		pvc, err := virtClient.CoreV1().PersistentVolumeClaims(vmi.Namespace).Get(context.Background(), backendstorage.PVCForVMI(vmi), metav1.GetOptions{})
+		Expect(err).NotTo(HaveOccurred())
+		Expect(pvc.Spec.StorageClassName).NotTo(BeNil())
+		Expect(*pvc.Spec.StorageClassName).To(Equal(storageClass))
+		Expect(pvc.Status.AccessModes).To(HaveLen(1))
+		Expect(pvc.Status.AccessModes[0]).To(Equal(corev1.ReadWriteOnce))
+
+		By("Expecting the VMI to be non-migratable")
+		vmi, err = virtClient.VirtualMachineInstance(vmi.Namespace).Get(context.Background(), vmi.Name, metav1.GetOptions{})
+		Expect(err).NotTo(HaveOccurred())
+		cond := controller.NewVirtualMachineInstanceConditionManager().GetCondition(vmi, v1.VirtualMachineInstanceIsMigratable)
+		Expect(cond).NotTo(BeNil(), "LiveMigratable condition not found")
+		Expect(cond.Status).To(Equal(corev1.ConditionFalse))
+		Expect(cond.Reason).To(Equal(v1.VirtualMachineInstanceReasonDisksNotMigratable))
+		Expect(cond.Message).To(ContainSubstring("Backend storage PVC is not RWX"))
+	})
+})