Skip to content

Commit

Permalink
tests, single stack ipv6: skip istio tests
Browse files Browse the repository at this point in the history
ipv6 support is in alpha stage on Istio u/s and is not supported yet
by kubevirt.

Note: even once ipv6 will be fully supported by istio, kubevirt may have
troubles to make it work for VMs because there is no IPv6 equialent to
"sysctl net.ipv4.conf.all.route_localnet".

Signed-off-by: Alona Kaplan <alkaplan@redhat.com>
  • Loading branch information
AlonaKaplan committed Mar 8, 2022
1 parent 06aafd5 commit a359d51
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions tests/network/vmi_istio.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ import (
"strings"
"time"

k8sv1 "k8s.io/api/core/v1"

expect "github.com/google/goexpect"
k8snetworkplumbingwgv1 "github.com/k8snetworkplumbingwg/network-attachment-definition-client/pkg/apis/k8s.cni.cncf.io/v1"
. "github.com/onsi/ginkgo"
Expand Down Expand Up @@ -99,7 +101,7 @@ var _ = SIGDescribe("[Serial] Istio", func() {
By("Getting back the VMI IP")
vmi, err = virtClient.VirtualMachineInstance(vmi.Namespace).Get(vmi.Name, &metav1.GetOptions{})
Expect(err).ShouldNot(HaveOccurred())
vmiIP := vmi.Status.Interfaces[0].IP
vmiIP := libnet.GetVmiPrimaryIpByFamily(vmi, k8sv1.IPv4Protocol)

By("Running job to send a request to the server")
return virtClient.BatchV1().Jobs(util.NamespaceTestDefault).Create(
Expand All @@ -114,6 +116,8 @@ var _ = SIGDescribe("[Serial] Istio", func() {
virtClient, err = kubecli.GetKubevirtClient()
util.PanicOnError(err)

libnet.SkipWhenClusterNotSupportIpv4(virtClient)

By("Create NetworkAttachmentDefinition")
nad := generateIstioCNINetworkAttachmentDefinition()
_, err = virtClient.NetworkClient().K8sCniCncfIoV1().NetworkAttachmentDefinitions(util.NamespaceTestDefault).Create(context.TODO(), nad, metav1.CreateOptions{})
Expand Down Expand Up @@ -217,7 +221,7 @@ var _ = SIGDescribe("[Serial] Istio", func() {
By("Getting the VMI IP")
vmi, err = virtClient.VirtualMachineInstance(vmi.Namespace).Get(vmi.Name, &metav1.GetOptions{})
Expect(err).ShouldNot(HaveOccurred())
vmiIP := vmi.Status.Interfaces[0].IP
vmiIP := libnet.GetVmiPrimaryIpByFamily(vmi, k8sv1.IPv4Protocol)

Expect(
checkSSHConnection(bastionVMI, "fedora", vmiIP),
Expand All @@ -232,7 +236,7 @@ var _ = SIGDescribe("[Serial] Istio", func() {
By("Getting the VMI IP")
vmi, err = virtClient.VirtualMachineInstance(vmi.Namespace).Get(vmi.Name, &metav1.GetOptions{})
Expect(err).ShouldNot(HaveOccurred())
vmiIP := vmi.Status.Interfaces[0].IP
vmiIP := libnet.GetVmiPrimaryIpByFamily(vmi, k8sv1.IPv4Protocol)

Expect(
checkSSHConnection(bastionVMI, "fedora", vmiIP),
Expand Down

0 comments on commit a359d51

Please sign in to comment.