Skip to content

Commit

Permalink
Reenable unsafeptr nogo rule
Browse files Browse the repository at this point in the history
Add rules_go_work- folder to exclusion rules instead.

Signed-off-by: Daniel Hiller <dhiller@redhat.com>
  • Loading branch information
dhiller committed May 11, 2021
1 parent 3716069 commit c76b0e8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
3 changes: 1 addition & 2 deletions BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,7 @@ nogo(
"@org_golang_x_tools//go/analysis/passes/structtag:go_tool_library",
"@org_golang_x_tools//go/analysis/passes/tests:go_tool_library",
"@org_golang_x_tools//go/analysis/passes/unreachable:go_tool_library",
# Fails on a vendored dependency, disabling for now.
# "@org_golang_x_tools//go/analysis/passes/unsafeptr:go_tool_library",
"@org_golang_x_tools//go/analysis/passes/unsafeptr:go_tool_library",
"@org_golang_x_tools//go/analysis/passes/unusedresult:go_tool_library",
],
)
Expand Down
1 change: 1 addition & 0 deletions nogo_config.json
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@
"unsafeptr": {
"exclude_files": {
"vendor/": "vendor doesn't pass vet",
"rules_go_work-.*/": "necessary due to https://github.com/bazelbuild/rules_go/issues/2513",
"external/": "externaldoesn't pass vet"
}
},
Expand Down

0 comments on commit c76b0e8

Please sign in to comment.