Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sidecar does not build out of tree #11817

Closed
aep opened this issue Apr 29, 2024 · 2 comments · Fixed by #11846
Closed

sidecar does not build out of tree #11817

aep opened this issue Apr 29, 2024 · 2 comments · Fixed by #11846
Assignees
Labels

Comments

@aep
Copy link

aep commented Apr 29, 2024

the sidecar example https://github.com/kubevirt/kubevirt/blob/main/cmd/sidecars/smbios/smbios.go
does not build when pulled out of tree.

go mod tidy
go: finding module for package kubevirt.io/kubevirt/pkg/virt-launcher/virtwrap/api
go: found kubevirt.io/kubevirt/pkg/virt-launcher/virtwrap/api in kubevirt.io/kubevirt v1.2.0
go: github.com/openshift/api@v0.0.0: reading github.com/openshift/api/go.mod at revision v0.0.0: unknown revision v0.0.0

there is a nice https://github.com/kubevirt/api package that would work just fine,
but its missing the virt-launcher/virtwrap/api

so currently to implement a sidecar, you need to fork kubevirt itself

@aep aep added the kind/bug label Apr 29, 2024
@alicefr
Copy link
Member

alicefr commented Apr 30, 2024

/cc @victortoso

@victortoso
Copy link
Member

The current usage of kubevirt.io/kubevirt/pkg/virt-launcher/virtwrap/api is only related to schema.go which means it can be replaced by libvirtxml, which is actually preferred. I'm working on doing that from virt-launcher side already too.

somewhat related: #10844
/assign

victortoso added a commit to victortoso/kubevirt that referenced this issue May 3, 2024
Simplify build of smbios to not require fetching KubeVirt itself to
build.

Fixes: kubevirt#11817
Signed-off-by: Victor Toso <victortoso@redhat.com>
Sreeja1725 pushed a commit to Sreeja1725/kubevirt that referenced this issue May 28, 2024
Simplify build of smbios to not require fetching KubeVirt itself to
build.

Fixes: kubevirt#11817
Signed-off-by: Victor Toso <victortoso@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants