-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
virtctl: use basename when printing help #2356
Labels
Comments
3 tasks
/assign |
dhiller
added a commit
to dhiller/kubevirt
that referenced
this issue
Jul 8, 2019
Replace hard coded `virtctl` by using the basename of the call, this enables nicer output when installed via krew plugin package manager. Fixes kubevirt#2356
dhiller
added a commit
to dhiller/kubevirt
that referenced
this issue
Jul 8, 2019
Replace hard coded `virtctl` by using the basename of the call, this enables nicer output when installed via krew plugin package manager. Fixes kubevirt#2356
dhiller
added a commit
to dhiller/kubevirt
that referenced
this issue
Jul 9, 2019
Replace hard coded `virtctl` by using the basename of the call, this enables nicer output when installed via krew plugin package manager. Fixes kubevirt#2356
dhiller
added a commit
to dhiller/kubevirt
that referenced
this issue
Jul 10, 2019
Replace hard coded `virtctl` by using the basename of the call, this enables nicer output when installed via krew plugin package manager. Fixes kubevirt#2356
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug
What happened:
When used as a krew plugin,
kubectl virt [help]
prints virtctl instead of kubectl virtWhat you expected to happen:
This is how it should be:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
from krew-index PR
Environment:
virtctl version
): Client Version: version.Info{GitVersion:"v0.17.0", GitCommit:"c0f960702dce718419a767f3913669f539229ff0", GitTreeState:"clean", BuildDate:"2019-05-05T08:09:14Z", GoVersion:"go1.11.5", Compiler:"gc", Platform:"linux/amd64"}kubectl version
): Client Version: version.Info{Major:"1", Minor:"12", GitVersion:"v1.12.5", GitCommit:"51dd616cdd25d6ee22c83a858773b607328a18ec", GitTreeState:"archive", BuildDate:"2019-03-05T13:36:50Z", GoVersion:"go1.12", Compiler:"gc", Platform:"linux/amd64"}uname -a
):The text was updated successfully, but these errors were encountered: