Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With our switch to CRDs it is now possible to give our VM it's final name "VirtualMachine" #439

Closed
rmohr opened this issue Sep 11, 2017 · 1 comment

Comments

@rmohr
Copy link
Member

rmohr commented Sep 11, 2017

So far, we used for our VirtualMachine object the name VM, to allow us doing simple things at the client side, like kubectl get vms in contrast to kubectl get virtualmachine. Now with CRDs in place, we can change it and use the proper VirtualMachine Kind and still keep the vm/vms convenience.

Our CRD should look like this:

apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
  name: virtualmachines.kubevirt.io
spec:
  group: kubevirt.io
  version: v1alpha1
  scope: Namespaced
  names:
    plural: virtualmachines
    singular: virtualmachine
    kind: VirtualMachines
    shortNames:
    - vm
    - vms

Minor code adjustments might be necessary (Replacing e.g. "VM" with "VirtualMachine").

@cynepco3hahue
Copy link

@rmohr Please assign to me.

mzzgaopeng pushed a commit to mzzgaopeng/kubevirt that referenced this issue Mar 8, 2021
vendor: Update vishvanana/netlink dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants