ControllerRevisions created by instancetype.kubevirt.io provide no resource version metadata

[lyarwood]

What happened:

NOTE I'm writing this up as a bug as I think it's valid to be backported to release-1.0 and possibly release-0.59.

Currently the ControllerRevisions created by instancetype.kubevirt.io provide no metadata about the version of the resource held inside. This makes it difficult to identify any ControllerRevisions that need to be migrated to a newer version etc.

./_kubevirt/cluster-up/kubectl.sh get vms/vm-bs4zz -o json | jq .spec.instancetype
selecting podman as container runtime
{
  "kind": "virtualmachineclusterinstancetype",
  "name": "n1.medium",
  "revisionName": "vm-bs4zz-n1.medium-863421ba-0039-499b-83dc-089f2c32395e-1"
}
./_kubevirt/cluster-up/kubectl.sh get controllerrevision/vm-bs4zz-n1.medium-863421ba-0039-499b-83dc-089f2c32395e-1 -o json | jq .metadata
selecting podman as container runtime
{
  "creationTimestamp": "2023-06-16T09:22:37Z",
  "name": "vm-bs4zz-n1.medium-863421ba-0039-499b-83dc-089f2c32395e-1",
  "namespace": "default",
  "ownerReferences": [
    {
      "apiVersion": "kubevirt.io/v1",
      "blockOwnerDeletion": true,
      "controller": true,
      "kind": "VirtualMachine",
      "name": "vm-bs4zz",
      "uid": "3c312197-167c-488c-afc1-99d7ed119148"
    }
  ],
  "resourceVersion": "26444",
  "uid": "ccb7f3a3-9a62-4cb5-ae1e-c13f3a83e45d"
}

What you expected to happen:

Start labelling these ControllerRevisions with the ResourceVersion of the resource held within so at some point in the future the labels could be used to orchestrate migrations to newer versions.

How to reproduce it (as minimally and precisely as possible):
N/A

Additional context:
N/A

Environment:

• KubeVirt version (use virtctl version): N/A
• Kubernetes version (use kubectl version): N/A
• VM or VMI specifications: N/A
• Cloud provider or hardware configuration: N/A
• OS (e.g. from /etc/os-release): N/A
• Kernel (e.g. uname -a): N/A
• Install tools: N/A
• Others: N/A

[lyarwood]

/area instancetype