instancetype: Label ControllerRevisions with stored object metadata

[lyarwood]

/area instancetype

What this PR does / why we need it:

ControllerRevisions are used to store point in time copies of instance
type and preference objects for each VirtualMachine making use of the
feature, see the following user-guide docs for more on this:

Instance types and preferences - Versioning
https://kubevirt.io/user-guide/virtual_machines/instancetypes/#versioning

This change adds labels to these ControllerRevision, exposing metadata
of the stored objects. With this in place it becomes easier to track the
objects stored within these ControllerRevisions and in the future
orchestrate the migration of these objects to newer versions of the API
and CRDs as these are introduced.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #9925

Special notes for your reviewer:

Release note:

`ControllerRevisions` containing `instancetype.kubevirt.io` `CRDs` are now decorated with labels detailing specific metadata of the underlying stashed object

[kubevirt-bot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[lyarwood]

/retest-required

[lyarwood]

/cc @0xFelix

[0xFelix]

Thanks!

Looks good to me. But this only helps converting newly created ControllerRevisions, right? We still need to figure out how to convert older existing ones?

I also like that his allows for deduplication of ControllerRevisions!

I assume functests are not needed at this point?

/lgtm

[lyarwood]

Thanks!

Looks good to me. But this only helps converting newly created ControllerRevisions, right? We still need to figure out how to convert older existing ones?

Yes I think any conversion is going to assume that these labels aren't present to be begin with.

I also like that his allows for deduplication of ControllerRevisions!

Yeah hopefully allows us to look things up quickly without relying on the names etc.

I assume functests are not needed at this point?

I didn't think so at this point but happy to add something if required.

I'm still not sure about the names tbh, I think these could easily conflict in their present form so I might make them a little more specific to the ControllerRevisions this morning.

[0xFelix]

/lgtm

[xpivarc]

/approve

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xpivarc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [xpivarc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kubevirt-commenter-bot]

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

[lyarwood]

/cherry-pick release-1.0

[kubevirt-bot]

@lyarwood: once the present PR merges, I will cherry-pick it on top of release-1.0 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kubevirt-bot]

@lyarwood: new pull request created: #10153

In response to this:

/cherry-pick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.