Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add operator-observability package #10044

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Add operator-observability package #10044

merged 2 commits into from
Sep 29, 2023

Conversation

machadovilaca
Copy link
Member

@machadovilaca machadovilaca commented Jul 5, 2023 •
edited
Loading

What this PR does / why we need it:

This PR adds https://github.com/machadovilaca/operator-observability as a vendored package, This dependency contains a set of utilities for Kubernetes Operators to help with observability while following Operator SDK Observability Best Practices

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

jira-ticket: https://issues.redhat.com/browse/CNV-29245

Release note:

Add operator-observability package

@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jul 5, 2023
@machadovilaca machadovilaca force-pushed the move-virt-controller-metrics branch 2 times, most recently from 048933c to 3474f96 Compare July 5, 2023 14:13
@machadovilaca
Copy link
Member Author

/test all

@machadovilaca
Copy link
Member Author

/test all

@machadovilaca
Copy link
Member Author

/test all

@machadovilaca machadovilaca marked this pull request as ready for review July 10, 2023 12:37
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2023
@machadovilaca
Copy link
Member Author

/cc @enp0s3

@kubevirt-bot kubevirt-bot requested a review from enp0s3 July 10, 2023 13:34
@machadovilaca machadovilaca force-pushed the move-virt-controller-metrics branch 2 times, most recently from ac0e54f to 741b941 Compare July 20, 2023 11:05
@maiqueb
Copy link
Contributor

maiqueb commented Jul 20, 2023

/uncc

@kubevirt-bot kubevirt-bot removed the request for review from maiqueb July 20, 2023 12:16
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2023
@kubevirt-bot kubevirt-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 14, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enp0s3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 26, 2023
@machadovilaca
Add operator-observability package
7197908 
Signed-off-by: João Vilaça <jvilaca@redhat.com>
@machadovilaca
Move virt-controller metrics to pkg/monitoring
e0453d1 
Signed-off-by: João Vilaça <jvilaca@redhat.com>
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 28, 2023
@sradco
Copy link
Contributor

sradco commented Sep 28, 2023

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2023
@kubevirt-bot kubevirt-bot merged commit 86ac08c into kubevirt:main Sep 29, 2023
38 checks passed
@machadovilaca machadovilaca mentioned this pull request Oct 18, 2023
Merged
@machadovilaca machadovilaca mentioned this pull request Oct 26, 2023
Closed
8 tasks
@avlitman avlitman mentioned this pull request Oct 29, 2023
Merged
11 tasks
@machadovilaca machadovilaca mentioned this pull request Oct 31, 2023
Merged
8 tasks
@machadovilaca machadovilaca mentioned this pull request Nov 8, 2023
Merged
8 tasks
This was referenced Nov 26, 2023
Merged
Merged
@avlitman avlitman mentioned this pull request Dec 17, 2023
Merged
@avlitman avlitman mentioned this pull request Dec 31, 2023
Merged
11 tasks
This was referenced Jan 14, 2024
Merged
Closed
Merged
@avlitman avlitman mentioned this pull request Feb 1, 2024
Merged
avlitman added a commit to avlitman/ssp-operator that referenced this pull request Feb 13, 2024
@avlitman
refactor recording rules and alerts code
8eaada4 
Following the work started in kubevirt/kubevirt#10044 , and according to
the kubevirt/community#219 proposal, this PR refactors monitoring
recording rules and alerts

Signed-off-by: avlitman <alitman@redhat.com>
avlitman added a commit to avlitman/ssp-operator that referenced this pull request Feb 13, 2024
@avlitman
refactor recording rules and alerts code
67be6bf 
Following the work started in kubevirt/kubevirt#10044 , and according to
the kubevirt/community#219 proposal, this PR refactors monitoring
recording rules and alerts

Signed-off-by: avlitman <alitman@redhat.com>
avlitman added a commit to avlitman/ssp-operator that referenced this pull request Feb 13, 2024
@avlitman
refactor recording rules and alerts code
01b15a9 
Following the work started in kubevirt/kubevirt#10044 , and according to
the kubevirt/community#219 proposal, this PR refactors monitoring
recording rules and alerts

Signed-off-by: avlitman <alitman@redhat.com>
avlitman added a commit to avlitman/ssp-operator that referenced this pull request Feb 13, 2024
@avlitman
refactor recording rules and alerts code
578b7b1 
Following the work started in kubevirt/kubevirt#10044 , and according to
the kubevirt/community#219 proposal, this PR refactors monitoring
recording rules and alerts

Signed-off-by: avlitman <alitman@redhat.com>
avlitman added a commit to avlitman/ssp-operator that referenced this pull request Feb 14, 2024
@avlitman
refactor recording rules and alerts code
b085db8 
Following the work started in kubevirt/kubevirt#10044 , and according to
the kubevirt/community#219 proposal, this PR refactors monitoring
recording rules and alerts

Signed-off-by: avlitman <alitman@redhat.com>
avlitman added a commit to avlitman/ssp-operator that referenced this pull request Feb 14, 2024
@avlitman
refactor recording rules and alerts code
4fd4022 
Following the work started in kubevirt/kubevirt#10044 , and according to
the kubevirt/community#219 proposal, this PR refactors monitoring
recording rules and alerts

Signed-off-by: avlitman <alitman@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enp0s3 enp0s3 enp0s3 left review comments

@lyarwood lyarwood Awaiting requested review from lyarwood

@rthallisey rthallisey Awaiting requested review from rthallisey

@stu-gott stu-gott Awaiting requested review from stu-gott

Assignees

@sradco sradco

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/monitoring dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@machadovilaca @kubevirt-bot @maiqueb @enp0s3 @sradco