Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix volume detach on hotplug attachment pod delete #10165

Merged
merged 2 commits into from
Jul 26, 2023

Commits on Jul 24, 2023

  1. Fix volume detach on hotplug attachment pod delete

    When the hotplug attachment pod is deleted, the VMI
    volumestatus goes back to bound, which triggers the
    manager to detach the volume from the running VM
    interrupting any IO on that volume. The pod is then
    re-created and the volume gets re-attached and operation
    can continue, but if the volume is mounted, it needs
    to be re-mounted in the VM.
    
    This commit modifies the logic so that if the volume is
    ready, it cannot go back to bound if the attachment pod
    disappears. This prevents the detachments and issues with
    IO on the running VM.
    
    Signed-off-by: Alexander Wels <awels@redhat.com>
    awels committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    bc0073f View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Address code review comments

    Remove unneeded phase check, and move other check into
    its own function in case we need more elaborate checks
    
    Signed-off-by: Alexander Wels <awels@redhat.com>
    awels committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    c733bee View commit details
    Browse the repository at this point in the history