Move coordination/lease RBAC permissions to Roles #10173
Conversation
Instead of giving virt-operator and virt-controller cluster-wide lease access, restrict the permissions to the install namespace. Signed-off-by: Roman Mohr <rmohr@google.com>
kubevirt-bot
added
release-note
|
/cherrypick release-1.0 |
|
@rmohr: once the present PR merges, I will cherry-pick it on top of release-1.0 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/lgtm |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xpivarc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
@rmohr: new pull request created: #10207 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Improve the best-effort filter so that it catches more mistakes. Recent PRs that ended up in the release notes but shouldn't have, and would have been caught by the improved filter: kubevirt/kubevirt#10173 kubevirt/kubevirt#10370 Signed-off-by: Andrea Bolognani <abologna@redhat.com>
What this PR does / why we need it:
Instead of giving virt-operator and virt-controller cluster-wide lease access, restrict the permissions to the install namespace.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: