Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for new hotplug attachment pod to be ready #10275

Merged
merged 4 commits into from Aug 14, 2023

Commits on Aug 11, 2023

  1. Wait for new attachemnt pod

    Before deleting old attachment pod, wait for new attachment
    pod to be ready, so k8s should not detach the volume from the
    node since there will always be a pod using the volume from
    its perspective.
    
    Fixed issue where when adding or removing a volume the existing
    volumes would still have the UID of the old attachment pod in
    the VMI status which caused errors to appear in the virt-handler
    logs about not being able to find the device or image.
    
    Fixed issue where the cleanup would attempt to remove a volume
    that was already gone causing errors to appear in the virt-handler
    log.
    
    Signed-off-by: Alexander Wels <awels@redhat.com>
    awels committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    cb98387 View commit details
    Browse the repository at this point in the history
  2. Don't generate SynFail caused by a race condition.

    Signed-off-by: Alexander Wels <awels@redhat.com>
    awels committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    b807364 View commit details
    Browse the repository at this point in the history
  3. Address code review comments

    Signed-off-by: Alexander Wels <awels@redhat.com>
    awels committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    60547c2 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. Update pkg/virt-handler/hotplug-disk/mount.go

    Co-authored-by: Vasiliy Ulyanov <vulyanov@suse.de>
    Signed-off-by: Alexander Wels <awels@redhat.com>
    awels and vasiliy-ul committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    c3c0251 View commit details
    Browse the repository at this point in the history