Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate net bind api and slirp hook sidecar #10289

Closed
wants to merge 10 commits into from
Closed

Integrate net bind api and slirp hook sidecar #10289

wants to merge 10 commits into from

Conversation

ormergi
Copy link
Contributor

@ormergi ormergi commented Aug 14, 2023 •
edited

What this PR does / why we need it:
Test integration between network binding plugin API #10284 and slirp hook-sidecar #10272

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
Rebased on #10284

Release note:

NONE

@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XXL kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Aug 14, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign davidvossel for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ormergi ormergi force-pushed the integrate-net-bind-API-and-slirp-hook-sidecar branch 2 times, most recently from 95532de to 1ada1d1 Compare August 15, 2023 09:26
@ormergi
Copy link
Contributor Author

ormergi commented Aug 15, 2023

/test pull-kubevirt-e2e-k8s-1.27-sig-network

@ormergi ormergi force-pushed the integrate-net-bind-API-and-slirp-hook-sidecar branch from 1ada1d1 to a5d8ce1 Compare August 15, 2023 11:29
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 15, 2023
@ormergi
Copy link
Contributor Author

ormergi commented Aug 15, 2023

/test pull-kubevirt-e2e-k8s-1.27-sig-network

@ormergi ormergi force-pushed the integrate-net-bind-API-and-slirp-hook-sidecar branch from a5d8ce1 to 46f7ea2 Compare August 15, 2023 14:01
@ormergi
Copy link
Contributor Author

ormergi commented Aug 15, 2023

/test pull-kubevirt-e2e-k8s-1.27-sig-network

@ormergi ormergi force-pushed the integrate-net-bind-API-and-slirp-hook-sidecar branch from 46f7ea2 to 9ae6f97 Compare August 16, 2023 11:43
@ormergi
Copy link
Contributor Author

ormergi commented Aug 16, 2023

/test pull-kubevirt-e2e-k8s-1.27-sig-network

@ormergi
slirp binding plugin: Introduce skeleton
990f016 
cmd/network-slirp-binding:
|_ callback
|_ server
slirp.go

server & slirp.go
  Boilerplate code for registration to Kubevrit's hooks.
  Can be replaced with sidecar-shim container in the future.
callback:
  Implement Kubevirt OnDefineDomain hook point callback.
  The DomainSpecMutator interface should be implemented by
  the concrete slirp binding implementation.

Slirp binding implementation will be introduced in follow-up commits.

Signed-off-by: Or Mergi <ormergi@redhat.com>
@ormergi
slirp binding plugin: Parse resolv.conf search domains
3879018 
resolv.conf search domains required for slirp networking
configuration.

Signed-off-by: Or Mergi <ormergi@redhat.com>
@ormergi ormergi force-pushed the integrate-net-bind-API-and-slirp-hook-sidecar branch from 9ae6f97 to 26e4c4d Compare August 17, 2023 06:21
@ormergi
Copy link
Contributor Author

ormergi commented Aug 17, 2023

/test pull-kubevirt-e2e-k8s-1.27-sig-network

@ormergi
slirp binding plugin: Implement slirp network configurator
2faae64 
Signed-off-by: Or Mergi <ormergi@redhat.com>
@ormergi
slirp binding plugin: Wire up slirp configurator to callback server
8fc6c5a 
Signed-off-by: Or Mergi <ormergi@redhat.com>
@ormergi
slirp binding plugin: Add bazel rule to push image to local registry
22cd66a 
Signed-off-by: Or Mergi <ormergi@redhat.com>
@ormergi
slirp binding plugin: Build & push image as part of cluster-sync
e27a7ea 
Signed-off-by: Or Mergi <ormergi@redhat.com>
@ormergi
slirp configurator: Support ifaces with network binding plugin
487446e 
Signed-off-by: Or Mergi <ormergi@redhat.com>
@ormergi ormergi force-pushed the integrate-net-bind-API-and-slirp-hook-sidecar branch from 26e4c4d to 609f3ee Compare August 17, 2023 14:27
@ormergi
Copy link
Contributor Author

ormergi commented Aug 17, 2023

/test pull-kubevirt-e2e-k8s-1.27-sig-network

@ormergi
DEBUG: Use slirp binding plugin sidecar to cofigure slirp network int…
904ebc6 
…erface

Signed-off-by: Or Mergi <ormergi@redhat.com>
@ormergi
DEBUG: Adapt unit tests following slirp hook-sidecar addition
3c24e36 
Some test were removed because they test unsupported scenrios
(e.g.: multiple slirp ifaces), or tests that covered by the
slirp hook-sidecar tests.

Other tests changed to not use slirp as default interface.

Signed-off-by: Or Mergi <ormergi@redhat.com>
@ormergi
DEBUG: Do not handle slirp interfaces as part of network setup
343f00b 
Slirp interfaces configured by slirp hook-sidecar.

Signed-off-by: Or Mergi <ormergi@redhat.com>
@ormergi ormergi force-pushed the integrate-net-bind-API-and-slirp-hook-sidecar branch from 609f3ee to 343f00b Compare August 17, 2023 14:31
@ormergi
Copy link
Contributor Author

ormergi commented Aug 17, 2023

/test pull-kubevirt-e2e-k8s-1.27-sig-network

@ormergi
Copy link
Contributor Author

ormergi commented Aug 21, 2023

/close

@kubevirt-bot
Copy link
Contributor

@ormergi: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlonaKaplan AlonaKaplan Awaiting requested review from AlonaKaplan

@qinqon qinqon Awaiting requested review from qinqon

@rthallisey rthallisey Awaiting requested review from rthallisey

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API release-note-none Denotes a PR that doesn't merit a release note. sig/network size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ormergi @kubevirt-bot