-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.0] Wait for new hotplug attachment pod to be ready #10292
[release-1.0] Wait for new hotplug attachment pod to be ready #10292
Conversation
Before deleting old attachment pod, wait for new attachment pod to be ready, so k8s should not detach the volume from the node since there will always be a pod using the volume from its perspective. Fixed issue where when adding or removing a volume the existing volumes would still have the UID of the old attachment pod in the VMI status which caused errors to appear in the virt-handler logs about not being able to find the device or image. Fixed issue where the cleanup would attempt to remove a volume that was already gone causing errors to appear in the virt-handler log. Signed-off-by: Alexander Wels <awels@redhat.com>
Signed-off-by: Alexander Wels <awels@redhat.com>
Signed-off-by: Alexander Wels <awels@redhat.com>
Co-authored-by: Vasiliy Ulyanov <vulyanov@suse.de> Signed-off-by: Alexander Wels <awels@redhat.com>
/test pull-kubevirt-e2e-k8s-1.25-sig-compute-migrations-1.0 |
/test pull-kubevirt-unit-test-1.0 |
/test pull-kubevirt-e2e-k8s-1.25-sig-storage-1.0 |
/test pull-kubevirt-e2e-k8s-1.27-sig-operator-1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidvossel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubevirt-e2e-k8s-1.25-sig-storage-1.0 |
@kubevirt-bot: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #10275
/assign awels