Allow image-upload to recover from PendingPopulation phase #10380
Conversation
|
Skipping CI for Draft Pull Request. |
kubevirt-bot
added
do-not-merge/work-in-progress
This commit fixes virtctl image-upload command so we allow recovering from PendingPopulation phase, as it did with WaitForFirstConsumer. This means that, if an image-upload fails due to a DV being in PendingPopulation phase, we can call the command again after creating a consumer and the upload will continue as expected. Signed-off-by: Alvaro Romero <alromero@redhat.com>
alromeros
force-pushed
the
improve-imageupload-populators
branch
from
a1ffd3c
to
7134205
Compare
kubevirt-bot
removed
the
do-not-merge/work-in-progress
|
/test pull-kubevirt-e2e-k8s-1.27-sig-compute |
|
/uncc @kbidarkar @EdDev @marceloamaral |
kubevirt-bot
requested review from
mhenriks
and removed request for
kbidarkar,
marceloamaral and
EdDev
|
Very nice! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhenriks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/cherry-pick release-1.0 |
|
@alromeros: new pull request created: #10397 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This PR aims to fix virtctl image-upload so we allow DVs to recover from
PendingPopulationphase, as we do withWaitForFirstConsumer.This means that, if an image-upload command fails due to a DV being in
PendingPopulationphase, we can call the command again after creating a consumer and the upload will continue as expected.Which issue(s) this PR fixes:
Fixes # https://bugzilla.redhat.com/show_bug.cgi?id=2236060
Special notes for your reviewer:
We have two ways of fixing this, either in CDI by adding the missing annotations into the target PVC, or in virtctl by getting the PVC Prime and checking its annotations. We generally attempt to ignore populator logic outside CDI, but I think that adding the annotations into the target PVC is a worse idea since it can mess with the upload controller.
Release note: