Support "Clone API" to filter virtualmachine.spec.template.annotation… #10658

matthewei · 2023-11-01T08:24:29Z

What this PR does / why we need it:
The label--annotation-filters strip it from the top-level just as your description and it can't strip from spec.template.metadata.annotation or labels. Some cni such as kube-ovn will inject network information into the annotation. So we need to filter them out.

please theck the following example.

spec:
  # labels & annotations definitions
  labelFilters:
  - "*"
  - "!someKey/*"
  annotationFilters:
  - "anotherKey/*"

  template: # 
    labelFilters:
    - "*"
    - "!someKey/*"
    annotationFilters:
    - "anotherKey/*"

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #10374

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Design: A design document was considered and is present (link) or not required
PR: The PR description is expressive enough and will help future contributors
Code: Write code that humans can understand and Keep it simple
Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
Upgrade: Impact of this change on upgrade flows was considered and addressed if required
Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
Community: Announcement to kubevirt-dev was considered

Release note:

1. Support "Clone API" to filter VirtualMachine.spec.template.annotation and VirtualMachine.spec.template.label

kubevirt-bot · 2023-11-01T08:24:39Z

Hi @matthewei. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

matthewei · 2023-11-01T08:38:22Z

/test

kubevirt-bot · 2023-11-01T08:38:38Z

@matthewei: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

matthewei · 2023-11-02T00:32:18Z

/ok-to-test

kubevirt-bot · 2023-11-02T00:32:34Z

@matthewei: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

matthewei · 2023-11-03T04:48:24Z

/needs-ok-test

matthewei · 2023-11-06T00:39:39Z

@0xFelix hello, I make a few mistakes on the #10469 so I raise a new PR. Please move to next step.

mhenriks · 2023-11-08T15:07:00Z

/ok-to-test

mhenriks · 2023-11-08T15:07:08Z

/cc @mhenriks

0xFelix · 2023-11-08T15:07:35Z

/cc @0xFelix

0xFelix

Looks OK to me but there are still failing tests. Can you please address those?

0xFelix · 2023-11-09T10:33:27Z

pkg/virt-api/webhooks/validating-webhook/admitters/vmclone-admitter.go

@@ -108,11 +114,12 @@ func validateFilters(filters []string, fieldName string) (causes []metav1.Status
 		return nil
 	}

+	errPattern := "%s filter %s is invalid: cannot contain a %s character (%s); FilterRules: %s"


nit: Keep definition of this at L129 and as const.

0xFelix · 2023-11-09T10:34:17Z

pkg/virtctl/create/clone/clone.go

Can you put the changes to virtctl into a separate commit?

yes, will do it

done ,will raise another PR

mhenriks · 2023-11-13T14:52:42Z

/retest-required

matthewei · 2023-11-14T11:42:12Z

Looks OK to me but there are still failing tests. Can you please address those?

I will check the e2e code.

matthewei · 2023-11-16T06:13:53Z

/retest-required

… or virtualmachine.spec.template.label Signed-off-by: shenwei <shenwei_yewu@cmss.chinamobile.com>

matthewei · 2023-11-17T01:06:00Z

/retest-required

matthewei · 2023-11-17T02:14:04Z

If this PR can be merged and I would like to modify clone_api.

matthewei · 2023-11-20T00:42:31Z

@0xFelix Hi, I have finished this PR. Please move to next step. Thanks a lot.

mhenriks · 2023-11-20T21:07:30Z

/approve

mhenriks · 2023-11-20T21:07:37Z

/retest-required

kubevirt-bot · 2023-11-20T21:07:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mhenriks]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

matthewei · 2023-11-21T12:05:00Z

can I raise a PR for clone_api?

0xFelix

Thanks!

/lgtm
/retest-required

0xFelix · 2023-11-21T13:39:19Z

can I raise a PR for clone_api?

You mean a PR for updating the docs on the clone API? Please go ahead!

kubevirt-commenter-bot · 2023-11-21T17:19:13Z

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

kubevirt-commenter-bot · 2023-11-21T20:19:14Z

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

kubevirt-commenter-bot · 2023-11-22T04:19:13Z

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

kubevirt-bot · 2023-11-22T04:59:41Z

@matthewei: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubevirt-goveralls	`0e7658d`	link	false	`/test pull-kubevirt-goveralls`
pull-kubevirt-check-tests-for-flakes	`0e7658d`	link	false	`/test pull-kubevirt-check-tests-for-flakes`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kubevirt-commenter-bot · 2023-11-22T07:19:17Z

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

kubevirt-bot requested review from 0xFelix and kbidarkar November 1, 2023 08:24

kubevirt-bot added size/L needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 1, 2023

matthewei mentioned this pull request Nov 1, 2023

Support "Clone API" to filter VirtualMachine.spec.template.annotation… #10469

Closed

8 tasks

kubevirt-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 8, 2023

kubevirt-bot requested a review from mhenriks November 8, 2023 15:07

0xFelix reviewed Nov 9, 2023

View reviewed changes

kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 14, 2023

matthewei force-pushed the cloneApiTemplateFilter branch from f553c48 to c4339bc Compare November 14, 2023 11:24

kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Nov 14, 2023

matthewei force-pushed the cloneApiTemplateFilter branch from c4339bc to 2bcf283 Compare November 15, 2023 01:16

matthewei force-pushed the cloneApiTemplateFilter branch from c0700c7 to 500b1f2 Compare November 15, 2023 06:11

matthewei requested a review from 0xFelix November 15, 2023 07:44

matthewei force-pushed the cloneApiTemplateFilter branch 2 times, most recently from 3765ca6 to 321e5b7 Compare November 16, 2023 05:09

matthewei force-pushed the cloneApiTemplateFilter branch 2 times, most recently from 3c29f05 to a39f1a5 Compare November 16, 2023 06:17

Support "Clone API" to filter virtualmachine.spec.template.annotation…

0e7658d

… or virtualmachine.spec.template.label Signed-off-by: shenwei <shenwei_yewu@cmss.chinamobile.com>

matthewei force-pushed the cloneApiTemplateFilter branch from a39f1a5 to 0e7658d Compare November 16, 2023 10:05

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2023

0xFelix reviewed Nov 21, 2023

View reviewed changes

kubevirt-bot assigned 0xFelix Nov 21, 2023

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2023

kubevirt-bot merged commit 041d8b0 into kubevirt:main Nov 22, 2023
34 of 36 checks passed

matthewei mentioned this pull request Nov 25, 2023

virtctl: cloneAPI add template filters #10787

Merged

8 tasks

chenrui333 mentioned this pull request Mar 6, 2024

virtctl 1.2.0 Homebrew/homebrew-core#165266

Merged

matthewei deleted the cloneApiTemplateFilter branch March 7, 2024 00:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support "Clone API" to filter virtualmachine.spec.template.annotation… #10658

Support "Clone API" to filter virtualmachine.spec.template.annotation… #10658

matthewei commented Nov 1, 2023

kubevirt-bot commented Nov 1, 2023

matthewei commented Nov 1, 2023

kubevirt-bot commented Nov 1, 2023

matthewei commented Nov 2, 2023

kubevirt-bot commented Nov 2, 2023

matthewei commented Nov 3, 2023

matthewei commented Nov 6, 2023 •

edited

mhenriks commented Nov 8, 2023

mhenriks commented Nov 8, 2023

0xFelix commented Nov 8, 2023

0xFelix left a comment

0xFelix Nov 9, 2023

matthewei Nov 13, 2023

matthewei Nov 15, 2023

0xFelix Nov 9, 2023

matthewei Nov 13, 2023

matthewei Nov 17, 2023

mhenriks commented Nov 13, 2023

matthewei commented Nov 14, 2023

matthewei commented Nov 16, 2023

matthewei commented Nov 17, 2023 •

edited

matthewei commented Nov 17, 2023

matthewei commented Nov 20, 2023

mhenriks commented Nov 20, 2023

mhenriks commented Nov 20, 2023

kubevirt-bot commented Nov 20, 2023

matthewei commented Nov 21, 2023 •

edited

0xFelix left a comment

0xFelix commented Nov 21, 2023

kubevirt-commenter-bot commented Nov 21, 2023

kubevirt-commenter-bot commented Nov 21, 2023

kubevirt-commenter-bot commented Nov 22, 2023

kubevirt-bot commented Nov 22, 2023 •

edited

kubevirt-commenter-bot commented Nov 22, 2023

Support "Clone API" to filter virtualmachine.spec.template.annotation… #10658

Support "Clone API" to filter virtualmachine.spec.template.annotation… #10658

Conversation

matthewei commented Nov 1, 2023

kubevirt-bot commented Nov 1, 2023

matthewei commented Nov 1, 2023

kubevirt-bot commented Nov 1, 2023

matthewei commented Nov 2, 2023

kubevirt-bot commented Nov 2, 2023

matthewei commented Nov 3, 2023

matthewei commented Nov 6, 2023 • edited

mhenriks commented Nov 8, 2023

mhenriks commented Nov 8, 2023

0xFelix commented Nov 8, 2023

0xFelix left a comment

Choose a reason for hiding this comment

0xFelix Nov 9, 2023

Choose a reason for hiding this comment

matthewei Nov 13, 2023

Choose a reason for hiding this comment

matthewei Nov 15, 2023

Choose a reason for hiding this comment

0xFelix Nov 9, 2023

Choose a reason for hiding this comment

matthewei Nov 13, 2023

Choose a reason for hiding this comment

matthewei Nov 17, 2023

Choose a reason for hiding this comment

mhenriks commented Nov 13, 2023

matthewei commented Nov 14, 2023

matthewei commented Nov 16, 2023

matthewei commented Nov 17, 2023 • edited

matthewei commented Nov 17, 2023

matthewei commented Nov 20, 2023

mhenriks commented Nov 20, 2023

mhenriks commented Nov 20, 2023

kubevirt-bot commented Nov 20, 2023

matthewei commented Nov 21, 2023 • edited

0xFelix left a comment

Choose a reason for hiding this comment

0xFelix commented Nov 21, 2023

kubevirt-commenter-bot commented Nov 21, 2023

kubevirt-commenter-bot commented Nov 21, 2023

kubevirt-commenter-bot commented Nov 22, 2023

kubevirt-bot commented Nov 22, 2023 • edited

kubevirt-commenter-bot commented Nov 22, 2023

matthewei commented Nov 6, 2023 •

edited

matthewei commented Nov 17, 2023 •

edited

matthewei commented Nov 21, 2023 •

edited

kubevirt-bot commented Nov 22, 2023 •

edited