Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.1] Introduce Passt network binding plugin #10669

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #10425

/assign ormergi

Introduce network binding plugin for Passt networking, interfacing with Kubevirt new network binding plugin API.

cmd/network-passt-binding:
 |_ callback
 |_ server
 main.go

server & main.go
  Boilerplate code for registration to Kubevrit's hooks.
  Can be replaced with sidecar-shim container in the future.
callback:
  Implement Kubevirt OnDefineDomain hook point callback.
  The DomainSpecMutator interface should be implemented by
  the concrete passt binding implementation.

passt binding implementation will be introduced in follow-up commits.

Signed-off-by: Or Mergi <ormergi@redhat.com>
The pod network configurator generates a domain interface
spec and add it to the given domian spec according to the given
VMI interface and network objects.

Signed-off-by: Or Mergi <ormergi@redhat.com>
Signed-off-by: Or Mergi <ormergi@redhat.com>
Signed-off-by: Or Mergi <ormergi@redhat.com>
Signed-off-by: Or Mergi <ormergi@redhat.com>
Signed-off-by: Or Mergi <ormergi@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 2, 2023
@ormergi
Copy link
Contributor

ormergi commented Nov 2, 2023

/cc @AlonaKaplan @EdDev

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2023
@AlonaKaplan
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlonaKaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2023
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot kubevirt-bot merged commit 30bae40 into kubevirt:release-1.1 Nov 5, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants