Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.1] Fix host usb permissions #10829

Merged
merged 2 commits into from
Dec 5, 2023
Merged

[release-1.1] Fix host usb permissions #10829

merged 2 commits into from
Dec 5, 2023

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #10753

/assign vasiliy-ul

Fixes device permission when using USB host passthrough

@victortoso
schema: add a const to USB type
a12690d 
To follow what PCI and MDEV are already doing.

Signed-off-by: Victor Toso <victortoso@redhat.com>
@victortoso
device-manager: usb: fix device permission
923b7b1 
Easy to verify that ownership of USB device was not being set
107:107. This is a problem when running as non root.

kubevirt#10727
Signed-off-by: Victor Toso <victortoso@redhat.com>
@kubevirt-bot kubevirt-bot mentioned this pull request Dec 4, 2023
Merged
8 tasks
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S labels Dec 4, 2023
xpivarc
xpivarc reviewed Dec 4, 2023
View reviewed changes
Copy link
Member

@xpivarc xpivarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xpivarc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2023
vasiliy-ul
vasiliy-ul approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@vasiliy-ul vasiliy-ul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest-required

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2023
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot
Copy link
Contributor Author

@kubevirt-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-e2e-arm64 923b7b1 link false /test pull-kubevirt-e2e-arm64-1.1
pull-kubevirt-unit-test 923b7b1 link unknown /test pull-kubevirt-unit-test-1.1
pull-kubevirt-e2e-kind-1.27-sriov 923b7b1 link unknown /test pull-kubevirt-e2e-kind-1.27-sriov-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vasiliy-ul
Copy link
Contributor

/retest-required

@kubevirt-bot kubevirt-bot merged commit 7e6de91 into kubevirt:release-1.1 Dec 5, 2023
33 of 36 checks passed
@kubevirt-bot kubevirt-bot mentioned this pull request Jan 2, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xpivarc xpivarc xpivarc left review comments

@vasiliy-ul vasiliy-ul vasiliy-ul approved these changes

@EdDev EdDev Awaiting requested review from EdDev

@kbidarkar kbidarkar Awaiting requested review from kbidarkar

Assignees

@vasiliy-ul vasiliy-ul

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kubevirt-bot @kubevirt-commenter-bot @vasiliy-ul @xpivarc @victortoso