Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.1] Allow LUN disks to be hotplugged #10909

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #10529

/assign alromeros

Allow LUN disks to be hotplugged

Signed-off-by: Alvaro Romero <alromero@redhat.com>
Signed-off-by: Alvaro Romero <alromero@redhat.com>
Signed-off-by: Alvaro Romero <alromero@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 20, 2023
@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xpivarc for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alromeros
Copy link
Contributor

/retest

@alromeros
Copy link
Contributor

/test pull-kubevirt-e2e-arm64-1.1

@jpeimer
Copy link

jpeimer commented Dec 24, 2023

/retest-required

@jpeimer
Copy link

jpeimer commented Jan 2, 2024

/test pull-kubevirt-e2e-arm64-1.1

2 similar comments
@alromeros
Copy link
Contributor

/test pull-kubevirt-e2e-arm64-1.1

@alromeros
Copy link
Contributor

/test pull-kubevirt-e2e-arm64-1.1

@kubevirt-bot
Copy link
Contributor Author

@kubevirt-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-e2e-arm64 e864f24 link false /test pull-kubevirt-e2e-arm64-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@alromeros
Copy link
Contributor

Hey @xpivarc, could you take a look for review/approval? Thanks!

@alicefr
Copy link
Member

alicefr commented Jan 4, 2024

This is more a feature then a bug fix. Please motivate why we need to backport it

@alromeros
Copy link
Contributor

This is the backend part of this bug https://issues.redhat.com/browse/CNV-29298 (which also involves UI). There was some discussion around this in the original bugzilla.

@mhenriks
Copy link
Member

This seems more like a bug fix to me. Not a new feature. Think it should be allowed. What do you think @xpivarc?

@alromeros
Copy link
Contributor

/close
Closing after discussing with engineering and several approvers: We have concluded that there's no fundamental reason to categorize this as a bug, and we think the lack of this feature doesn't break any workflow to justify its backport.

@kubevirt-bot
Copy link
Contributor Author

@alromeros: Closed this PR.

In response to this:

/close
Closing after discussing with engineering and several approvers: We have concluded that there's no fundamental reason to categorize this as a bug, and we think the lack of this feature doesn't break any workflow to justify its backport.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants