-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.1] Allow LUN disks to be hotplugged #10909
[release-1.1] Allow LUN disks to be hotplugged #10909
Conversation
Signed-off-by: Alvaro Romero <alromero@redhat.com>
Signed-off-by: Alvaro Romero <alromero@redhat.com>
Signed-off-by: Alvaro Romero <alromero@redhat.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test pull-kubevirt-e2e-arm64-1.1 |
/retest-required |
/test pull-kubevirt-e2e-arm64-1.1 |
2 similar comments
/test pull-kubevirt-e2e-arm64-1.1 |
/test pull-kubevirt-e2e-arm64-1.1 |
@kubevirt-bot: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hey @xpivarc, could you take a look for review/approval? Thanks! |
This is more a feature then a bug fix. Please motivate why we need to backport it |
This is the backend part of this bug https://issues.redhat.com/browse/CNV-29298 (which also involves UI). There was some discussion around this in the original bugzilla. |
This seems more like a bug fix to me. Not a new feature. Think it should be allowed. What do you think @xpivarc? |
/close |
@alromeros: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #10529
/assign alromeros