infra: Bump Go to version 1.21.5 #10914
Conversation
Includes the updated builder image Signed-off-by: Brian Carey <bcarey@redhat.com>
kubevirt-bot
added
release-note
Signed-off-by: Brian Carey <bcarey@redhat.com>
brianmcarey
force-pushed
the
go-1.21.5
branch
2 times, most recently
from
bfc4157
to
edd2e7c
Compare
tests/migration/migration.go
Outdated
| @@ -1615,10 +1615,10 @@ var _ = SIGMigrationDescribe("VM Live Migration", func() { | |||
| By("checking that we were never able to connect") | |||
| tlsErrorFound := false | |||
| for err := range errors { | |||
| if strings.Contains(err.Error(), "remote error: tls: bad certificate") { | |||
| if strings.Contains(err.Error(), "remote error: tls: unknown certificate authority") { | |||
There was a problem hiding this comment.
This has to change in go implementation. It would be great to reference the commit.
There was a problem hiding this comment.
Added this information to the commit - 5cd924b
tests/migration/migration.go
Outdated
| tlsErrorFound = true | ||
| } | ||
| Expect(err.Error()).To(Or(ContainSubstring("remote error: tls: bad certificate"), ContainSubstring("EOF"))) | ||
| Expect(err.Error()).To(Or(ContainSubstring("remote error: tls: unknown certificate authority"), ContainSubstring("EOF"))) |
There was a problem hiding this comment.
Worth adding another Or to support some not-Kubevirt builds.
There was a problem hiding this comment.
Thanks @xpivarc for spotting that - Added.
The compute-migrations test lane was failing[1] due to a mismatch in TLS error strings TLS error handling was improved in go 1.21[2] [1] https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/10914/pull-kubevirt-e2e-k8s-1.28-sig-compute-migrations/1737851138511736832 [2] golang/go@62a9948 Signed-off-by: Brian Carey <bcarey@redhat.com>
brianmcarey
force-pushed
the
go-1.21.5
branch
from
edd2e7c
to
5cd924b
Compare
Signed-off-by: Brian Carey <bcarey@redhat.com>
|
/retest The new builder image hadn't been fully published. |
After the update of golangci-lint - there were still a couple of lint errors[1] [1] https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/10914/pull-kubevirt-code-lint/1738136816302690304 Signed-off-by: Brian Carey <bcarey@redhat.com>
kubevirt-bot
added
size/M
and removed
lgtm
| @@ -849,7 +849,8 @@ func (m *InstancetypeMethods) inferDefaultsFromDataVolume(vm *virtv1.VirtualMach | |||
| if dvt.Name != dvName { | |||
| continue | |||
| } | |||
| return m.inferDefaultsFromDataVolumeSpec(&dvt.Spec, defaultNameLabel, defaultKindLabel, vm.Namespace) | |||
| dvtSpec := dvt.Spec | |||
There was a problem hiding this comment.
It was causing the following lint error after the update of golangci-lint
pkg/instancetype/instancetype.go:852:45: G601: Implicit memory aliasing in for loop. (gosec)
return m.inferDefaultsFromDataVolumeSpec(&dvt.Spec, defaultNameLabel, defaultKindLabel, vm.Namespace)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xpivarc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
@brianmcarey: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required |
What this PR does / why we need it:
Kubernetes 1.29 is being built with Go 1.21.5[1] - the next release of KubeVirt will be targeting kubernetes 1.29 so we should try to build with Go 1.21.5
[1] kubernetes/kubernetes#122201
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
[ ] Design: A design document was considered and is present (link) or not required[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.[ ] Community: Announcement to kubevirt-dev was consideredRelease note: