[release-1.0] enable live migration with dedicated cpus and isolated emulator thread #11015

acardace · 2024-01-12T14:46:28Z

Manual cherry-pick of #9722 + make generate run to fix dates.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Design: A design document was considered and is present (link) or not required
PR: The PR description is expressive enough and will help future contributors
Code: Write code that humans can understand and Keep it simple
Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
Upgrade: Impact of this change on upgrade flows was considered and addressed if required
Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
Community: Announcement to kubevirt-dev was considered

Release note:

NONE

Blocking live migration with isolated emulator thread was introduced due to a misunderstanding: there is nothing that prevents a VM, with isolated emulator thread, to be live migrated (since the VM configuration, including emulator thread isolation, happens at VM initialization time). Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>

Signed-off-by: Antonio Cardace <acardace@redhat.com>

fossedihelm · 2024-01-12T14:49:54Z

I don't know if there will be conflicts with #11012
/lgtm

acardace · 2024-01-12T15:10:24Z

I don't know if there will be conflicts with #11012 /lgtm

Let's see if this passes all tests before that one, in that case we'll hold #11012

acardace · 2024-01-19T08:28:20Z

/retest-required

dhiller · 2024-01-19T09:01:08Z

/test pull-kubevirt-goveralls

kubevirt-bot · 2024-01-19T09:01:38Z

@dhiller: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-kubevirt-apidocs-1.0
/test pull-kubevirt-build-1.0
/test pull-kubevirt-build-arm64-1.0
/test pull-kubevirt-check-unassigned-tests-1.0
/test pull-kubevirt-client-python-1.0
/test pull-kubevirt-e2e-k8s-1.25-ipv6-sig-network-1.0
/test pull-kubevirt-e2e-k8s-1.25-sig-compute-1.0
/test pull-kubevirt-e2e-k8s-1.25-sig-compute-cgroupsv2-1.0
/test pull-kubevirt-e2e-k8s-1.25-sig-compute-migrations-1.0
/test pull-kubevirt-e2e-k8s-1.25-sig-network-1.0
/test pull-kubevirt-e2e-k8s-1.25-sig-operator-1.0
/test pull-kubevirt-e2e-k8s-1.25-sig-performance-1.0
/test pull-kubevirt-e2e-k8s-1.25-sig-storage-1.0
/test pull-kubevirt-e2e-k8s-1.25-sig-storage-cgroupsv2-1.0
/test pull-kubevirt-e2e-k8s-1.26-sig-compute-1.0
/test pull-kubevirt-e2e-k8s-1.26-sig-monitoring-1.0
/test pull-kubevirt-e2e-k8s-1.26-sig-network-1.0
/test pull-kubevirt-e2e-k8s-1.26-sig-operator-1.0
/test pull-kubevirt-e2e-k8s-1.26-sig-storage-1.0
/test pull-kubevirt-e2e-k8s-1.27-sig-compute-1.0
/test pull-kubevirt-e2e-k8s-1.27-sig-network-1.0
/test pull-kubevirt-e2e-k8s-1.27-sig-operator-1.0
/test pull-kubevirt-e2e-k8s-1.27-sig-storage-1.0
/test pull-kubevirt-e2e-kind-1.25-vgpu-1.0
/test pull-kubevirt-e2e-kind-1.27-sriov-1.0
/test pull-kubevirt-e2e-windows2016-1.0
/test pull-kubevirt-generate-1.0
/test pull-kubevirt-manifests-1.0
/test pull-kubevirt-prom-rules-verify-1.0
/test pull-kubevirt-unit-test-1.0
/test pull-kubevirt-verify-go-mod-1.0

The following commands are available to trigger optional jobs:

/test build-kubevirt-builder-1.0
/test pull-kubevirt-check-tests-for-flakes-1.0
/test pull-kubevirt-code-lint-1.0
/test pull-kubevirt-e2e-arm64-1.0
/test pull-kubevirt-e2e-k8s-1.25-fips-sig-compute-1.0
/test pull-kubevirt-e2e-k8s-1.26-ipv6-sig-network-1.0
/test pull-kubevirt-e2e-k8s-1.26-sig-network-multus-v4-1.0
/test pull-kubevirt-e2e-k8s-1.26-single-node-1.0
/test pull-kubevirt-e2e-k8s-1.26-swap-enabled-1.0
/test pull-kubevirt-gosec-1.0
/test pull-kubevirt-goveralls-1.0
/test pull-kubevirt-unit-test-arm64-1.0
/test pull-kubevirt-verify-rpms-1.0

Use /test all to run the following jobs that were automatically triggered:

pull-kubevirt-apidocs-1.0
pull-kubevirt-build-1.0
pull-kubevirt-build-arm64-1.0
pull-kubevirt-check-tests-for-flakes-1.0
pull-kubevirt-check-unassigned-tests-1.0
pull-kubevirt-client-python-1.0
pull-kubevirt-code-lint-1.0
pull-kubevirt-e2e-arm64-1.0
pull-kubevirt-e2e-k8s-1.25-ipv6-sig-network-1.0
pull-kubevirt-e2e-k8s-1.25-sig-compute-1.0
pull-kubevirt-e2e-k8s-1.25-sig-compute-migrations-1.0
pull-kubevirt-e2e-k8s-1.25-sig-network-1.0
pull-kubevirt-e2e-k8s-1.25-sig-operator-1.0
pull-kubevirt-e2e-k8s-1.25-sig-performance-1.0
pull-kubevirt-e2e-k8s-1.25-sig-storage-1.0
pull-kubevirt-e2e-k8s-1.26-sig-compute-1.0
pull-kubevirt-e2e-k8s-1.26-sig-network-1.0
pull-kubevirt-e2e-k8s-1.26-sig-operator-1.0
pull-kubevirt-e2e-k8s-1.26-sig-storage-1.0
pull-kubevirt-e2e-k8s-1.27-sig-compute-1.0
pull-kubevirt-e2e-k8s-1.27-sig-network-1.0
pull-kubevirt-e2e-k8s-1.27-sig-operator-1.0
pull-kubevirt-e2e-k8s-1.27-sig-storage-1.0
pull-kubevirt-e2e-kind-1.25-vgpu-1.0
pull-kubevirt-e2e-kind-1.27-sriov-1.0
pull-kubevirt-e2e-windows2016-1.0
pull-kubevirt-generate-1.0
pull-kubevirt-goveralls-1.0
pull-kubevirt-manifests-1.0
pull-kubevirt-prom-rules-verify-1.0
pull-kubevirt-unit-test-1.0
pull-kubevirt-unit-test-arm64-1.0
pull-kubevirt-verify-go-mod-1.0

In response to this:

/test pull-kubevirt-goveralls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dhiller · 2024-01-19T09:03:20Z

@acardace how can this be a manual cherry pick of #9722, which has only 2 changed files with a couple of lines removed?

dhiller · 2024-01-19T09:06:20Z

I would at least expect some explanation which backports had to be made additionally in the PR description, so people can follow along.

acardace · 2024-01-19T09:35:19Z

I would at least expect some explanation which backports had to be made additionally in the PR description, so people can follow along.

It wasn't an additional backport, I just had to run make generate separately and I did a separate commit for that so that it's pretty clear that this is a backport + make generate.

https://github.com/kubevirt/kubevirt/pull/11015/commits

dhiller · 2024-01-23T15:18:18Z

I would at least expect some explanation which backports had to be made additionally in the PR description, so people can follow along.

It wasn't an additional backport, I just had to run make generate separately and I did a separate commit for that so that it's pretty clear that this is a backport + make generate.

https://github.com/kubevirt/kubevirt/pull/11015/commits

Thank you for clarifying, and I'll take the blame of not backporting the year removal fix :(

dhiller

/approve

kubevirt-bot · 2024-01-23T15:21:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dhiller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot · 2024-01-23T21:08:08Z

@acardace: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubevirt-goveralls	`49e86ec`	link	false	`/test pull-kubevirt-goveralls-1.0`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kubevirt-commenter-bot · 2024-01-23T23:54:02Z

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

acardace requested review from fossedihelm and xpivarc January 12, 2024 14:46

kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 12, 2024

kubevirt-bot requested review from 0xFelix and maiqueb January 12, 2024 14:46

run make generate to update dates

49e86ec

Signed-off-by: Antonio Cardace <acardace@redhat.com>

acardace force-pushed the cherrypick-9722 branch from 4b4e6da to 49e86ec Compare January 12, 2024 14:47

kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jan 12, 2024

acardace removed request for 0xFelix and maiqueb January 12, 2024 14:47

kubevirt-bot assigned fossedihelm Jan 12, 2024

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2024

fossedihelm approved these changes Jan 12, 2024

View reviewed changes

kbidarkar mentioned this pull request Jan 16, 2024

[release-1.0] enable live migration with dedicated cpus and isolated emulator thread #11009

Closed

dhiller reviewed Jan 23, 2024

View reviewed changes

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2024

kubevirt-bot merged commit b5e06f1 into kubevirt:release-1.0 Jan 24, 2024
33 of 34 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release-1.0] enable live migration with dedicated cpus and isolated emulator thread #11015

[release-1.0] enable live migration with dedicated cpus and isolated emulator thread #11015

acardace commented Jan 12, 2024 •

edited

fossedihelm commented Jan 12, 2024

acardace commented Jan 12, 2024

acardace commented Jan 19, 2024

dhiller commented Jan 19, 2024

kubevirt-bot commented Jan 19, 2024

dhiller commented Jan 19, 2024

dhiller commented Jan 19, 2024

acardace commented Jan 19, 2024 •

edited

dhiller commented Jan 23, 2024

dhiller left a comment

kubevirt-bot commented Jan 23, 2024

kubevirt-bot commented Jan 23, 2024 •

edited

kubevirt-commenter-bot commented Jan 23, 2024

[release-1.0] enable live migration with dedicated cpus and isolated emulator thread #11015

[release-1.0] enable live migration with dedicated cpus and isolated emulator thread #11015

Conversation

acardace commented Jan 12, 2024 • edited

fossedihelm commented Jan 12, 2024

acardace commented Jan 12, 2024

acardace commented Jan 19, 2024

dhiller commented Jan 19, 2024

kubevirt-bot commented Jan 19, 2024

dhiller commented Jan 19, 2024

dhiller commented Jan 19, 2024

acardace commented Jan 19, 2024 • edited

dhiller commented Jan 23, 2024

dhiller left a comment

Choose a reason for hiding this comment

kubevirt-bot commented Jan 23, 2024

kubevirt-bot commented Jan 23, 2024 • edited

kubevirt-commenter-bot commented Jan 23, 2024

acardace commented Jan 12, 2024 •

edited

acardace commented Jan 19, 2024 •

edited

kubevirt-bot commented Jan 23, 2024 •

edited