Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ginkgolinter in make lint #11107

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Enable ginkgolinter in make lint #11107

merged 2 commits into from
Feb 5, 2024

Conversation

nunnatsa
Copy link
Contributor

What this PR does / why we need it

re-enable ginkgo linter and fix two findings.

These two findings are actually bugs in the functional test, where an Eventually container is running with no assertion.

Release note:

None

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Jan 30, 2024
xpivarc
xpivarc reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@xpivarc xpivarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
See #11101

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2024
@nunnatsa
Copy link
Contributor Author

Removed the fixes in tests/vm_test.go. Waiting for #11101 to fix them

@nunnatsa nunnatsa marked this pull request as draft January 30, 2024 07:26
@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2024
@nunnatsa
Copy link
Contributor Author

/test pull-kubevirt-code-lint

@nunnatsa
Copy link
Contributor Author

/test pull-kubevirt-code-lint

@nunnatsa
Copy link
Contributor Author

/test pull-kubevirt-code-lint

@nunnatsa nunnatsa closed this Feb 4, 2024
@nunnatsa
Copy link
Contributor Author

nunnatsa commented Feb 4, 2024

/reopen

@kubevirt-bot
Copy link
Contributor

@nunnatsa: Failed to re-open PR: state cannot be changed. There are no new commits on the nunnatsa:enable-ginkgolinter branch.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Contributor Author

nunnatsa commented Feb 4, 2024

/reopen

@kubevirt-bot
Copy link
Contributor

@nunnatsa: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot reopened this Feb 4, 2024
@nunnatsa
Copy link
Contributor Author

nunnatsa commented Feb 4, 2024

/test pull-kubevirt-code-lint

1 similar comment
@nunnatsa
Copy link
Contributor Author

nunnatsa commented Feb 4, 2024

/test pull-kubevirt-code-lint

@nunnatsa
Enable ginkgolinter in Make lint
25afd9b 
re-enable ginkgo linter

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@nunnatsa
Copy link
Contributor Author

nunnatsa commented Feb 5, 2024

/test pull-kubevirt-code-lint

@nunnatsa nunnatsa marked this pull request as ready for review February 5, 2024 07:01
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2024
@nunnatsa
fix compilatio error in functest
9882dd0 
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@nunnatsa
Copy link
Contributor Author

nunnatsa commented Feb 5, 2024

@xpivarc - could you please take a look?

@nunnatsa nunnatsa requested a review from xpivarc February 5, 2024 07:33
@enp0s3
Copy link
Contributor

enp0s3 commented Feb 5, 2024

/sig buildsystem

@kubevirt-bot
Copy link
Contributor

@enp0s3: The label(s) sig/buildsystem cannot be applied, because the repository doesn't have them.

In response to this:

/sig buildsystem

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@enp0s3
Copy link
Contributor

enp0s3 commented Feb 5, 2024

/approve
tested make lint locally, passed
@nunnatsa Thank you!

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enp0s3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2024
EdDev
EdDev approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@EdDev EdDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2024
@kubevirt-commenter-bot
Copy link

Required labels detected, running phase 2 presubmits:
/test pull-kubevirt-e2e-windows2016
/test pull-kubevirt-e2e-kind-1.27-vgpu
/test pull-kubevirt-e2e-kind-1.27-sriov
/test pull-kubevirt-e2e-k8s-1.29-ipv6-sig-network
/test pull-kubevirt-e2e-k8s-1.27-sig-network
/test pull-kubevirt-e2e-k8s-1.27-sig-storage
/test pull-kubevirt-e2e-k8s-1.27-sig-compute
/test pull-kubevirt-e2e-k8s-1.27-sig-operator
/test pull-kubevirt-e2e-k8s-1.28-sig-network
/test pull-kubevirt-e2e-k8s-1.28-sig-storage
/test pull-kubevirt-e2e-k8s-1.28-sig-compute
/test pull-kubevirt-e2e-k8s-1.28-sig-operator

@EdDev
Copy link
Member

EdDev commented Feb 5, 2024

/hold See #11101

@xpivarc , the ref PR is merged and this one is rebased on master.
Can we remove the hold?

@nunnatsa
Copy link
Contributor Author

nunnatsa commented Feb 5, 2024

/test pull-kubevirt-unit-test

@nunnatsa
Copy link
Contributor Author

nunnatsa commented Feb 5, 2024

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2024
@kubevirt-bot kubevirt-bot merged commit f24a461 into kubevirt:main Feb 5, 2024
35 of 36 checks passed
@nunnatsa nunnatsa deleted the enable-ginkgolinter branch February 5, 2024 12:52
@nunnatsa nunnatsa changed the title Enable ginkgolinter in Make lint Enable ginkgolinter in make lint Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdDev EdDev EdDev approved these changes

@kbidarkar kbidarkar Awaiting requested review from kbidarkar

@stu-gott stu-gott Awaiting requested review from stu-gott

@mhenriks mhenriks Awaiting requested review from mhenriks

@xpivarc xpivarc Awaiting requested review from xpivarc

Assignees

@EdDev EdDev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nunnatsa @kubevirt-bot @enp0s3 @kubevirt-commenter-bot @EdDev @xpivarc