virtctl: Allow size to be optional when creating VMs

[0xFelix]

What this PR does

Allow to omit size when creating a VM and using --volume-import to clone a PVC or a VolumeSnapshot.

Before this PR:

Specifying size when creating a VM and using --volume-import to clone a PVC or a VolumeSnapshot was always required.

After this PR:

Specifying size when creating a VM and using --volume-import to clone a PVC or a VolumeSnapshot is optional now.

Fixes #

Why we need it and why it was done in this way

The following tradeoffs were made:

The following alternatives were considered:

Links to places where the discussion took place:

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

• Design: A design document was considered and is present (link) or not required
• PR: The PR description is expressive enough and will help future contributors
• Code: Write code that humans can understand and Keep it simple
• Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
• Upgrade: Impact of this change on upgrade flows was considered and addressed if required
• Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
• Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
• Community: Announcement to kubevirt-dev was considered

Release note

virtctl: Specifying size when creating a VM and using --volume-import to clone a PVC or a VolumeSnapshot is optional now

[alicefr]

@0xFelix a super nit, if you can split the ErrorNotFound type in a separate commit

[alicefr]

The code looks good to me! Thanks for the work
/approve

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alicefr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alicefr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fossedihelm]

Thanks @0xFelix!
One super nit that you can ignore.
Feel free to unhold
/hold

[fossedihelm]

nit: I'd prefer

Suggested change

	var volumeImportSizeOptional = map[string]bool{
	pvc: true,
	snapshot: true,
	}
	var volumeImportSizeMandatory = map[string]bool{
	pvc: false,
	snapshot: false,
	}

and save a not operation below.
But maybe it is my brain that starts burning when it see more than one negation :)

[kubevirt-commenter-bot]

Required labels detected, running phase 2 presubmits:
/test pull-kubevirt-e2e-windows2016
/test pull-kubevirt-e2e-kind-1.27-vgpu
/test pull-kubevirt-e2e-kind-sriov
/test pull-kubevirt-e2e-k8s-1.29-ipv6-sig-network
/test pull-kubevirt-e2e-k8s-1.27-sig-network
/test pull-kubevirt-e2e-k8s-1.27-sig-storage
/test pull-kubevirt-e2e-k8s-1.27-sig-compute
/test pull-kubevirt-e2e-k8s-1.27-sig-operator
/test pull-kubevirt-e2e-k8s-1.28-sig-network
/test pull-kubevirt-e2e-k8s-1.28-sig-storage
/test pull-kubevirt-e2e-k8s-1.28-sig-compute
/test pull-kubevirt-e2e-k8s-1.28-sig-operator

[0xFelix]

/hold cancel

Discussed this offline, will keep as is.

[0xFelix]

/retest