ownership, sig-buildsystem: add reviewers, add OWNERS files #11183
Conversation
|
Skipping CI for Draft Pull Request. |
kubevirt-bot
added
do-not-merge/work-in-progress
dhiller
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xpivarc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
dhiller
changed the title
|
/cc @fabiand FYI |
|
@dhiller: GitHub didn't allow me to request PR reviews from the following users: FYI. Note that only kubevirt members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
dhiller
force-pushed
the
add-sig-buildsystem-owners
branch
from
10f64db
to
e66333a
Compare
|
owner parts lgtm /lgtm |
|
/verify-owners |
| @@ -0,0 +1,6 @@ | |||
| reviewers: | |||
There was a problem hiding this comment.
cluster-up is a copy of the kubevirtci. I don't think we need a kubevirt owner for it.
There was a problem hiding this comment.
Even though the process is largely automated, there are still situations where we need to look into things. My intent was
a) to be clear about who is responsible for the bumping process and
b) to make sure that sig-buildsystem is assigned to the kubevirtci bumps, so that problems arising are picked up directly by us.
Doesn't that make sense?
There was a problem hiding this comment.
Yes, makes sense. Thanks for explaining.
kubevirt-bot
removed
the
do-not-merge/work-in-progress
|
/retest-required |
1 similar comment
|
/retest-required |
|
🛑 please refrain from manual retesting. /hold |
kubevirt-bot
added
the
do-not-merge/hold
dhiller
force-pushed
the
add-sig-buildsystem-owners
branch
from
e66333a
to
db24e1e
Compare
|
/test pull-kubevirt-generate |
|
/test pull-kubevirt-e2e-k8s-1.29-sig-storage |
kubevirt-bot
added
the
needs-rebase
Adds some more reviewers to the sig-buildsystem, also places some OWNERS files and extends the group of reviewers. Furthermore modifies bump-kubevirtci to restore the OWNERS file after actual update of kubevirtci. Signed-off-by: Daniel Hiller <dhiller@redhat.com>
dhiller
force-pushed
the
add-sig-buildsystem-owners
branch
from
db24e1e
to
5b60624
Compare
kubevirt-bot
removed
the
needs-rebase
|
/unhold |
kubevirt-bot
removed
the
do-not-merge/hold
|
Required labels detected, running phase 2 presubmits: |
|
/retest-required |
|
Mild flake on pull-kubevirt-e2e-k8s-1.27-sig-compute /override pull-kubevirt-e2e-k8s-1.27-sig-compute Mild flake on pull-kubevirt-e2e-k8s-1.29-sig-operator /override pull-kubevirt-e2e-k8s-1.29-sig-operator |
|
@dhiller: Overrode contexts on behalf of dhiller: pull-kubevirt-e2e-k8s-1.27-sig-compute, pull-kubevirt-e2e-k8s-1.29-sig-operator In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm What is missing here? |
|
@fabiand not sure - seems tide is stuck somehow 🤷 |
|
Seems like prow is retesting #11109 (7e4fe04) by RamLavi https://prow.ci.kubevirt.io/?repo=kubevirt%2Fkubevirt&type=batch |
|
@dhiller: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What this PR does
Before this PR:
The special files and folders for build system components, i.e.
automation/were lacking OWNERS, so that most PRs changing these were assigned to the global reviewers group.After this PR:
Some more reviewers to the sig-buildsystem, also some OWNERS files are placed and the group of reviewers is extended. This makes reviews of PRs that change build system components to be assigned to the build system folks.
Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
We surely have not hit everything in this first run, but follow up PRs can refine this matter.
The following alternatives were considered:
Links to places where the discussion took place: To be added
Special notes for your reviewer
/cc @brianmcarey @enp0s3 @xpivarc
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note