Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.2] Fix migration when VM has rng devices and hotplugged block volume #11242

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #11205

/assign acardace

Fix migration breaking in case the VM has an rng device after hotplugging a block volume on cgroupsv2

…olume

To achieve hotplug functionality on cgroupsv2, we reconstruct the container device allowlist to add the new disk.
Today, we "forget" to re-add /dev/urandom to this list depending on whether it's needed (rng device in vmi).

Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
…ration test

Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L sig/storage labels Feb 14, 2024
@acardace
Copy link
Member

/approve

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2024
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2024
@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acardace

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot
Copy link
Contributor Author

kubevirt-bot commented Feb 14, 2024

@kubevirt-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-e2e-arm64 36ec4d8 link false /test pull-kubevirt-e2e-arm64-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@acardace
Copy link
Member

/override pull-kubevirt-e2e-k8s-1.28-sig-storage
The failure It's not related to the PR, it's a flake being addressed by #11245.

@kubevirt-bot
Copy link
Contributor Author

@acardace: Overrode contexts on behalf of acardace: pull-kubevirt-e2e-k8s-1.28-sig-storage

In response to this:

/override pull-kubevirt-e2e-k8s-1.28-sig-storage
The failure It's not related to the PR, it's a flake being addressed by #11245.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit cbc12b3 into kubevirt:release-1.2 Feb 14, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants