Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpm: Update virtualization packages #11256

Merged
merged 6 commits into from May 8, 2024
Merged

rpm: Update virtualization packages #11256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
370e186
tests: Fix memory hotplug tests
andreabolognani Mar 5, 2024
fea574d
tests: Don't include memory sizes in messages
andreabolognani Mar 5, 2024
3ef238f
tests: Fix enabling ssh password authentication
andreabolognani Apr 8, 2024
bc73991
workspace: Switch to Alpine 3.19
andreabolognani Mar 1, 2024
cd48748
rpm: Update virtualization packages
andreabolognani Jan 24, 2024
4a67066
vendor: Update libvirt.org/go/libvirt
andreabolognani Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1,859 changes: 981 additions & 878 deletions WORKSPACE
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions go.mod
View file
Open in desktop
Expand Up @@ -79,8 +79,8 @@ require (
kubevirt.io/containerized-data-importer-api v1.57.0-alpha1
kubevirt.io/controller-lifecycle-operator-sdk/api v0.0.0-20220329064328-f3cc58c6ed90
kubevirt.io/qe-tools v0.1.8
libvirt.org/go/libvirt v1.9004.0
libvirt.org/go/libvirtxml v1.9008.0
libvirt.org/go/libvirt v1.10000.0
libvirt.org/go/libvirtxml v1.10000.0
mvdan.cc/sh/v3 v3.1.1
sigs.k8s.io/yaml v1.3.0
)
Expand Down
8 changes: 4 additions & 4 deletions go.sum
View file
Open in desktop
Expand Up @@ -1528,10 +1528,10 @@ kubevirt.io/controller-lifecycle-operator-sdk/api v0.0.0-20220329064328-f3cc58c6
kubevirt.io/controller-lifecycle-operator-sdk/api v0.0.0-20220329064328-f3cc58c6ed90/go.mod h1:018lASpFYBsYN6XwmA2TIrPCx6e0gviTd/ZNtSitKgc=
kubevirt.io/qe-tools v0.1.8 h1:Ar7qicmzHdd+Ia+6rjHDg3D7GReIyq7QFXoC4F7TjhQ=
kubevirt.io/qe-tools v0.1.8/go.mod h1:+Tr/WZGHIDQa/4pQgzM7+4J6YeVbUWAXESXtL2/zxqc=
libvirt.org/go/libvirt v1.9004.0 h1:u+CHhs2OhVmu0MWzBDrlbLzQ5QB3ZfWtfT+lD3EaUIs=
libvirt.org/go/libvirt v1.9004.0/go.mod h1:1WiFE8EjZfq+FCVog+rvr1yatKbKZ9FaFMZgEqxEJqQ=
libvirt.org/go/libvirtxml v1.9008.0 h1:xo2U9SqUsufTFtbyjiqs6oDdF329cvtRdqttWN7eojk=
libvirt.org/go/libvirtxml v1.9008.0/go.mod h1:7Oq2BLDstLr/XtoQD8Fr3mfDNrzlI3utYKySXF2xkng=
libvirt.org/go/libvirt v1.10000.0 h1:fPVWdvZz8TSmMrTnsStih9ETsHlrzIgSEEiFzOLbhO8=
libvirt.org/go/libvirt v1.10000.0/go.mod h1:1WiFE8EjZfq+FCVog+rvr1yatKbKZ9FaFMZgEqxEJqQ=
libvirt.org/go/libvirtxml v1.10000.0 h1:KPZXcmqUoJaJai95et+TEZegUQkFzCJgf1A59BOWpZQ=
libvirt.org/go/libvirtxml v1.10000.0/go.mod h1:7Oq2BLDstLr/XtoQD8Fr3mfDNrzlI3utYKySXF2xkng=
mvdan.cc/editorconfig v0.1.1-0.20200121172147-e40951bde157 h1:VBYz8greWWP8BDpRX0v7SDv/8rNlZVmdHdO4ZSsHj/E=
mvdan.cc/editorconfig v0.1.1-0.20200121172147-e40951bde157/go.mod h1:Ge4atmRUYqueGppvJ7JNrtqpqokoJEFxYbP0Z+WeKS8=
mvdan.cc/sh/v3 v3.1.1 h1:niuYC5Ug0KzLuN6CNX3ru37v4MkVD5Wm9T4Mk2eJr9A=
Expand Down
2 changes: 1 addition & 1 deletion hack/bootstrap.sh
View file
Open in desktop
Expand Up @@ -26,7 +26,7 @@ KUBEVIRT_NO_BAZEL=${KUBEVIRT_NO_BAZEL:-false}
HOST_ARCHITECTURE="$(uname -m)"

sandbox_root=${SANDBOX_DIR}/default/root
sandbox_hash="79cda77c407489645571b68ea8e8e6f813b99fdd"
sandbox_hash="c6dbbf8c168c0c37dac8f0ecbbfb694e0841e173"

function kubevirt::bootstrap::regenerate() {
(
Expand Down
16 changes: 8 additions & 8 deletions hack/rpm-deps.sh
View file
Open in desktop
Expand Up @@ -6,14 +6,14 @@ source hack/common.sh
source hack/bootstrap.sh
source hack/config.sh

LIBVIRT_VERSION=${LIBVIRT_VERSION:-0:9.5.0-6.el9}
QEMU_VERSION=${QEMU_VERSION:-17:8.0.0-13.el9}
SEABIOS_VERSION=${SEABIOS_VERSION:-0:1.16.1-1.el9}
EDK2_VERSION=${EDK2_VERSION:-0:20230524-3.el9}
LIBGUESTFS_VERSION=${LIBGUESTFS_VERSION:-1:1.50.1-6.el9}
GUESTFSTOOLS_VERSION=${GUESTFSTOOLS_VERSION:-0:1.50.1-3.el9}
PASST_VERSION=${PASST_VERSION:-0:0^20230818.g0af928e-4.el9}
VIRTIOFSD_VERSION=${VIRTIOFSD_VERSION:-0:1.7.2-1.el9}
LIBVIRT_VERSION=${LIBVIRT_VERSION:-0:10.0.0-7.el9}
QEMU_VERSION=${QEMU_VERSION:-17:8.2.0-11.el9}
SEABIOS_VERSION=${SEABIOS_VERSION:-0:1.16.3-2.el9}
EDK2_VERSION=${EDK2_VERSION:-0:20231122-6.el9}
LIBGUESTFS_VERSION=${LIBGUESTFS_VERSION:-1:1.50.1-7.el9}
GUESTFSTOOLS_VERSION=${GUESTFSTOOLS_VERSION:-0:1.51.6-2.el9}
PASST_VERSION=${PASST_VERSION:-0:0^20231204.gb86afe3-1.el9}
VIRTIOFSD_VERSION=${VIRTIOFSD_VERSION:-0:1.10.1-1.el9}
SWTPM_VERSION=${SWTPM_VERSION:-0:0.8.0-1.el9}
SINGLE_ARCH=${SINGLE_ARCH:-""}
BASESYSTEM=${BASESYSTEM:-"centos-stream-release"}
Expand Down
1,894 changes: 1,011 additions & 883 deletions rpm/BUILD.bazel
View file
Open in desktop

Large diffs are not rendered by default.

13 changes: 7 additions & 6 deletions tests/hotplug/memory.go
View file
Open in desktop
Expand Up @@ -60,8 +60,9 @@ var _ = Describe("[sig-compute][Serial]Memory Hotplug", decorators.SigCompute, d
Context("A VM with memory liveUpdate enabled", func() {

createHotplugVM := func(guest, maxGuest *resource.Quantity, sockets *uint32, maxSockets uint32) (*v1.VirtualMachine, *v1.VirtualMachineInstance) {
vmi := libvmifact.NewAlpineWithTestTooling(
libnet.WithMasqueradeNetworking()...,
vmi := libvmifact.NewAlpineWithTestTooling(append(
libnet.WithMasqueradeNetworking(),
libvmi.WithResourceMemory(guest.String()))...,
)
vmi.Namespace = testsuite.GetTestNamespace(vmi)
vmi.Spec.Domain.Memory = &v1.Memory{
Expand Down Expand Up @@ -106,15 +107,15 @@ var _ = Describe("[sig-compute][Serial]Memory Hotplug", decorators.SigCompute, d
migrationBandwidthLimit := resource.MustParse("1Ki")
migration.CreateMigrationPolicy(virtClient, migration.PreparePolicyAndVMIWithBandwidthLimitation(vmi, migrationBandwidthLimit))

By("Ensuring the compute container has at least 128Mi of memory")
By("Ensuring the compute container has the expected memory")
compute, err := libpod.LookupComputeContainerFromVmi(vmi)
Expect(err).ToNot(HaveOccurred())

Expect(compute).NotTo(BeNil(), "failed to find compute container")
reqMemory := compute.Resources.Requests.Memory().Value()
Expect(reqMemory).To(BeNumerically(">=", guest.Value()))

By("Hotplug 128Mi of memory")
By("Hotplug additional memory")
patchData, err := patch.GenerateTestReplacePatch("/spec/template/spec/domain/memory/guest", "128Mi", "256Mi")
Expect(err).NotTo(HaveOccurred())
_, err = virtClient.VirtualMachine(vm.Namespace).Patch(context.Background(), vm.Name, types.JSONPatchType, patchData, k8smetav1.PatchOptions{})
Expand Down Expand Up @@ -152,7 +153,7 @@ var _ = Describe("[sig-compute][Serial]Memory Hotplug", decorators.SigCompute, d
return vmi.Status.Memory.GuestCurrent.Value()
}, 240*time.Second, time.Second).Should(BeNumerically(">", guest.Value()))

By("Ensuring the virt-launcher pod now has at least more than 256Mi of memory")
By("Ensuring the virt-launcher pod now has more memory")
compute, err = libpod.LookupComputeContainerFromVmi(vmi)
Expect(err).ToNot(HaveOccurred())
Expect(compute).NotTo(BeNil(), "failed to find compute container")
Expand All @@ -166,7 +167,7 @@ var _ = Describe("[sig-compute][Serial]Memory Hotplug", decorators.SigCompute, d
maxGuest := resource.MustParse("512Mi")
vm, vmi := createHotplugVM(&guest, &maxGuest, nil, 0)

By("Hotplug 128Mi of memory")
By("Hotplug additional memory")
newGuestMemory := resource.MustParse("256Mi")
patchData, err := patch.GenerateTestReplacePatch("/spec/template/spec/domain/memory/guest", guest.String(), newGuestMemory.String())
Expect(err).NotTo(HaveOccurred())
Expand Down
4 changes: 1 addition & 3 deletions tests/network/vmi_istio.go
View file
Open in desktop
Expand Up @@ -530,9 +530,7 @@ func createPasstVm(ports []v1.Port) *v1.VirtualMachineInstance {
}

func enablePasswordAuth() string {
sedCmd := "sed -ri 's/PasswordAuthentication no/PasswordAuthentication yes/' /etc/ssh/sshd_config"

return "#!/bin/sh\n" + sedCmd + "\n"
return "#cloud-config\nssh_pwauth: true\n"
}

func generateIstioCNINetworkAttachmentDefinition() *k8snetworkplumbingwgv1.NetworkAttachmentDefinition {
Expand Down
24 changes: 22 additions & 2 deletions vendor/libvirt.org/go/libvirt/connect.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

88 changes: 44 additions & 44 deletions vendor/libvirt.org/go/libvirt/doc.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 11 additions & 7 deletions vendor/libvirt.org/go/libvirt/domain.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions vendor/libvirt.org/go/libvirt/error.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions vendor/libvirt.org/go/libvirt/libvirt_generated_callbacks.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.