build: Bump go to version 1.22.2 #11482
Open
+11,515
−11,804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note
kubevirt-bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dhiller The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
removed
the
approved
brianmcarey
changed the title
kubevirt-bot
added
the
needs-rebase
Kubernetes is building with go version 1.22[1] KubeVirt should align with this. go v1.22.2 includes a security fix for net/http and some more bug fixes[2] Build KubeVirt with go v1.22.2 [1] https://github.com/kubernetes/kubernetes/blob/b3926d137cd2964cd3a04088ded30845910547b1/go.mod#L9 [2] https://github.com/golang/go/issues?q=milestone%3AGo1.22.2+label%3ACherryPickApproved Signed-off-by: Brian Carey <bcarey@redhat.com>
rule_go v0.46.0 has support for go v1.22[1] [1] https://github.com/bazelbuild/rules_go/releases/tag/v0.46.0 Signed-off-by: Brian Carey <bcarey@redhat.com>
`make generate` fails with a panic with the current version Signed-off-by: Brian Carey <bcarey@redhat.com>
Signed-off-by: Brian Carey <bcarey@redhat.com>
kubevirt-bot
removed
the
needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Kubernetes is building with go version 1.22[1]
KubeVirt should align with this.
go v1.22.2 includes a security fix for net/http and some more bug
fixes[2]
Build KubeVirt with go v1.22.2
[1] https://github.com/kubernetes/kubernetes/blob/b3926d137cd2964cd3a04088ded30845910547b1/go.mod#L9
[2] https://github.com/golang/go/issues?q=milestone%3AGo1.22.2+label%3ACherryPickApproved
Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer
Majority of changes come from
make generatechanging the formatting of descriptions - 8bf4abfChecklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note