Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactoring: use well known LabelHostname constant #11553

Merged
merged 1 commit into from Mar 27, 2024
Merged

refactoring: use well known LabelHostname constant #11553

merged 1 commit into from Mar 27, 2024

Conversation

fossedihelm
Copy link
Contributor

What this PR does

kubernetes.io/hostname is a well-known label that we are using as a plain string. Switch using the constant provided by k8s.

Before this PR:
kubernetes.io/hostname is used as a plain string
After this PR:
LabelHostname constant is used

Fixes #

Why we need it and why it was done in this way

The following tradeoffs were made:

The following alternatives were considered:

Links to places where the discussion took place:

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 20, 2024
@kubevirt-bot kubevirt-bot added size/L kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/network sig/storage labels Mar 20, 2024
orelmisan
orelmisan approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@orelmisan orelmisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the cleanup @fossedihelm

nit: There is one more under pkg/virt-handler/node-labeller/cpu_plugin_test.go.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2024
@kubevirt-bot kubevirt-bot added sig/compute and removed lgtm Indicates that a PR is ready to be merged. labels Mar 20, 2024
@fossedihelm
Copy link
Contributor Author

Thank you for the cleanup @fossedihelm

nit: There is one more under pkg/virt-handler/node-labeller/cpu_plugin_test.go.

Thank you! I missed it :)

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2024
EdDev
EdDev approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@EdDev EdDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

fossedihelm
fossedihelm commented Mar 25, 2024
View reviewed changes
pkg/virt-handler/node-labeller/cpu_plugin_test.go Outdated
@@ -362,7 +362,7 @@ var nodeLabels = map[string]string{
"hyperv.node.kubevirt.io/tlbflush": "true",
"hyperv.node.kubevirt.io/vpindex": "true",
"kubernetes.io/arch": "amd64",
"kubernetes.io/hostname": "node01",
k8sv1.NamespaceDefault: "node01",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong one 🤦‍♂️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@fossedihelm
refactoring: use well known LabelHostname constant
3dbf033 
"kubernetes.io/hostname" is a well known label that we are using
as plain string. Switch using the constant provided by k8s.

Signed-off-by: fossedihelm <ffossemo@redhat.com>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024
@fossedihelm
Copy link
Contributor Author

@EdDev @orelmisan Fixed wrong constant and rebased.

orelmisan
orelmisan approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@orelmisan orelmisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024
@kubevirt-bot
Copy link
Contributor

@fossedihelm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-check-tests-for-flakes 3dbf033 link false /test pull-kubevirt-check-tests-for-flakes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jean-edouard
jean-edouard reviewed Mar 26, 2024
View reviewed changes
Copy link
Contributor

@jean-edouard jean-edouard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jean-edouard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2024
@kubevirt-commenter-bot
Copy link

Required labels detected, running phase 2 presubmits:
/test pull-kubevirt-e2e-windows2016
/test pull-kubevirt-e2e-kind-1.27-vgpu
/test pull-kubevirt-e2e-kind-sriov
/test pull-kubevirt-e2e-k8s-1.29-ipv6-sig-network
/test pull-kubevirt-e2e-k8s-1.27-sig-network
/test pull-kubevirt-e2e-k8s-1.27-sig-storage
/test pull-kubevirt-e2e-k8s-1.27-sig-compute
/test pull-kubevirt-e2e-k8s-1.27-sig-operator
/test pull-kubevirt-e2e-k8s-1.28-sig-network
/test pull-kubevirt-e2e-k8s-1.28-sig-storage
/test pull-kubevirt-e2e-k8s-1.28-sig-compute
/test pull-kubevirt-e2e-k8s-1.28-sig-operator

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot kubevirt-bot merged commit 403588d into kubevirt:main Mar 27, 2024
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jean-edouard jean-edouard jean-edouard left review comments

@orelmisan orelmisan orelmisan approved these changes

@EdDev EdDev EdDev approved these changes

@awels awels Awaiting requested review from awels

@enp0s3 enp0s3 Awaiting requested review from enp0s3

@kbidarkar kbidarkar Awaiting requested review from kbidarkar

Assignees

@EdDev EdDev

@orelmisan orelmisan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/compute sig/network sig/storage size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@fossedihelm @kubevirt-bot @kubevirt-commenter-bot @jean-edouard @EdDev @orelmisan