Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/utils.go: Remove unused function #11581

Closed
wants to merge 1 commit into from

Conversation

Barakmor1
Copy link
Member

What this PR does

Before this PR:

After this PR:

Fixes #

Why we need it and why it was done in this way

The following tradeoffs were made:

The following alternatives were considered:

Links to places where the discussion took place:

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note

NONE

Signed-off-by: bmordeha <bmordeha@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 24, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xpivarc for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Barakmor1
Copy link
Member Author

/sig code-quality

@kubevirt-bot
Copy link
Contributor

@Barakmor1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-conformance-arm64 c1db1b4 link false /test pull-kubevirt-conformance-arm64
pull-kubevirt-e2e-arm64 c1db1b4 link false /test pull-kubevirt-e2e-arm64
pull-kubevirt-e2e-k8s-1.29-sig-operator c1db1b4 link true /test pull-kubevirt-e2e-k8s-1.29-sig-operator
pull-kubevirt-e2e-k8s-1.29-sig-network c1db1b4 link true /test pull-kubevirt-e2e-k8s-1.29-sig-network
pull-kubevirt-e2e-k8s-1.29-sig-compute c1db1b4 link true /test pull-kubevirt-e2e-k8s-1.29-sig-compute
pull-kubevirt-check-unassigned-tests c1db1b4 link true /test pull-kubevirt-check-unassigned-tests
pull-kubevirt-e2e-k8s-1.29-sig-compute-migrations c1db1b4 link true /test pull-kubevirt-e2e-k8s-1.29-sig-compute-migrations
pull-kubevirt-e2e-k8s-1.29-sig-storage c1db1b4 link true /test pull-kubevirt-e2e-k8s-1.29-sig-storage
pull-kubevirt-check-tests-for-flakes c1db1b4 link false /test pull-kubevirt-check-tests-for-flakes
pull-kubevirt-code-lint c1db1b4 link true /test pull-kubevirt-code-lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Barakmor1
Copy link
Member Author

/close

@kubevirt-bot
Copy link
Contributor

@Barakmor1: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Barakmor1
Copy link
Member Author

IDE confused me that function is being used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. sig/code-quality size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants