Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.2] Update vmsnapshot error phase in case of volumesnapshot errors which prevent the snapshot from being ready #11582

Merged
merged 5 commits into from Mar 31, 2024
Merged

[release-1.2] Update vmsnapshot error phase in case of volumesnapshot errors which prevent the snapshot from being ready #11582

merged 5 commits into from Mar 31, 2024

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #11095

/assign ShellyKa13

Expose volumesnapshot error in vmsnapshot object

@ShellyKa13
Add error to vmsnapshot if has volumesnapshot error
4bd33fe 
Update vmsnapshot conditions and Error in the status
accordingly. In case error is removed the snapshot can
continue.

Signed-off-by: Shelly Kagan <skagan@redhat.com>
@ShellyKa13
cosmetic change - move the indications update to a function
be359ab 
Signed-off-by: Shelly Kagan <skagan@redhat.com>
@ShellyKa13
Add UT to check update of error state
28534de 
Signed-off-by: Shelly Kagan <skagan@redhat.com>
@ShellyKa13
Add missing UT for vmsnapshot deadlineexceeded
dc07764 
Signed-off-by: Shelly Kagan <skagan@redhat.com>
@ShellyKa13
Add functional test to check vmsnapshot in error state
2ef27b0 
Signed-off-by: Shelly Kagan <skagan@redhat.com>
@kubevirt-bot kubevirt-bot mentioned this pull request Mar 24, 2024
Merged
8 tasks
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 24, 2024
0xFelix
0xFelix approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024
@mhenriks
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2024
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

10 similar comments
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

6 similar comments
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

brianmcarey added a commit to brianmcarey/project-infra that referenced this pull request Mar 30, 2024
@brianmcarey
kubevirt,v1.2: Remove bazel cache from kubevirt v1.2 presubmits
24bd62b 
Cache evictions are causing the v1.2 presubmits to fail[1] - remove the
bazel cache for the v1.2 lanes.

[1] kubevirt/kubevirt#11582

Signed-off-by: Brian Carey <bcarey@redhat.com>
@brianmcarey brianmcarey mentioned this pull request Mar 30, 2024
Merged
8 tasks
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

2 similar comments
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@ShellyKa13
Copy link
Contributor

/hold
There is an issue with 1.2 backups, wait until kubevirt/project-infra#3332 merges

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2024
kubevirt-bot pushed a commit to kubevirt/project-infra that referenced this pull request Mar 31, 2024
@brianmcarey
kubevirt,v1.2: Remove bazel cache from kubevirt v1.2 presubmits (#3332)
dc59d43 
Cache evictions are causing the v1.2 presubmits to fail[1] - remove the
bazel cache for the v1.2 lanes.

[1] kubevirt/kubevirt#11582

Signed-off-by: Brian Carey <bcarey@redhat.com>
@brianmcarey
Copy link
Member

/retest

@ShellyKa13
Copy link
Contributor

/unhold
/retest

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2024
@kubevirt-bot
Copy link
Contributor Author

kubevirt-bot commented Mar 31, 2024 •
edited

@kubevirt-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-e2e-arm64 2ef27b0 link false /test pull-kubevirt-e2e-arm64-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot kubevirt-bot merged commit 2b90c7b into kubevirt:release-1.2 Mar 31, 2024
33 of 35 checks passed
@kubevirt-bot kubevirt-bot mentioned this pull request Apr 17, 2024
Closed
Barakmor1 pushed a commit to Barakmor1/project-infra that referenced this pull request Apr 24, 2024
@brianmcarey @Barakmor1
kubevirt,v1.2: Remove bazel cache from kubevirt v1.2 presubmits (kube…
78e1986 
…virt#3332)

Cache evictions are causing the v1.2 presubmits to fail[1] - remove the
bazel cache for the v1.2 lanes.

[1] kubevirt/kubevirt#11582

Signed-off-by: Brian Carey <bcarey@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix approved these changes

@akalenyu akalenyu Awaiting requested review from akalenyu

@awels awels Awaiting requested review from awels

Assignees

@0xFelix 0xFelix

@ShellyKa13 ShellyKa13

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kubevirt-bot @mhenriks @kubevirt-commenter-bot @ShellyKa13 @brianmcarey @0xFelix