Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor metrics domainstats #11601

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Refactor metrics domainstats #11601

wants to merge 6 commits into from

Conversation

machadovilaca
Copy link
Member

@machadovilaca machadovilaca commented Mar 26, 2024 •
edited

What this PR does

Before this PR:

domainstats were not refactor accordingly to kubevirt/community#219

After this PR:

domainstats are refactored

Fixes #

jira-ticket: https://issues.redhat.com/browse/CNV-38133

Why we need it and why it was done in this way

The following tradeoffs were made:

The following alternatives were considered:

Links to places where the discussion took place:

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note

none

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XXL labels Mar 26, 2024
@kubevirt-bot kubevirt-bot added area/monitoring kind/build-change Categorizes PRs as related to changing build files of virt-* components sig/buildsystem Denotes an issue or PR that relates to changes in the build system. sig/scale labels Mar 26, 2024
@avlitman avlitman mentioned this pull request Apr 8, 2024
Closed
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 9, 2024
@kubevirt-bot kubevirt-bot added sig/observability Denotes an issue or PR that relates to observability. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 11, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign vasiliy-ul for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@machadovilaca machadovilaca force-pushed the refactor-metrics-domainstats branch 3 times, most recently from 8180122 to 8bd0228 Compare April 15, 2024 16:06
@machadovilaca
Copy link
Member Author

/retest

@machadovilaca machadovilaca force-pushed the refactor-metrics-domainstats branch 2 times, most recently from 6b0a987 to 87538ba Compare April 16, 2024 14:49
@machadovilaca
Copy link
Member Author

/retest

machadovilaca
machadovilaca commented Apr 17, 2024
View reviewed changes
tests/monitoring/component_monitoring.go
@@ -236,7 +236,7 @@ var _ = Describe("[Serial][sig-monitoring]Component Monitoring", Serial, decorat
}, 5*time.Minute, 500*time.Millisecond).Should(Succeed())
})

It("VirtHandlerRESTErrorsBurst and VirtHandlerRESTErrorsHigh should be triggered when requests to virt-handler are failing", func() {
PIt("VirtHandlerRESTErrorsBurst and VirtHandlerRESTErrorsHigh should be triggered when requests to virt-handler are failing", func() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the E2E tests for virt-handler were having the same flakiness as 415964c#diff-5973bd8e1862c32cabfb41df6b9f6ebd8c81eb221b43965d12779f2476514579R224

I also marked it as pending to check them later together

ref: 0c086a0

@machadovilaca machadovilaca force-pushed the refactor-metrics-domainstats branch 2 times, most recently from c1b865b to 86cad03 Compare April 22, 2024 09:54
@assafad
Copy link
Contributor

assafad commented Apr 22, 2024

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2024
@assafad
Copy link
Contributor

assafad commented Apr 24, 2024

@machadovilaca I think pull-kubevirt-e2e-k8s-1.29-sig-compute is failing because of the PR changes. Seems related to kubevirt_vmi_vcpu_seconds_total metric.

@machadovilaca
Copy link
Member Author

/retest

@machadovilaca
Move virt-handler prometheus handler to pkg/monitoring/metrics/virt-h…
d5d43d1 
…andler

Signed-off-by: machadovilaca <machadovilaca@gmail.com>
@machadovilaca
Move virt-handler version metric
2bf52a3 
Signed-off-by: machadovilaca <machadovilaca@gmail.com>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2024
@machadovilaca
Refactor domainstats metrics
c841ee0 
Signed-off-by: machadovilaca <machadovilaca@gmail.com>
@machadovilaca
Refactor domainstats collector
8435866 
Signed-off-by: machadovilaca <machadovilaca@gmail.com>
@machadovilaca
Update metrics documentation generator
86211c2 
Signed-off-by: machadovilaca <machadovilaca@gmail.com>
@machadovilaca
tests: PIT flaky virt-handler component monitoring test
cf5aabb 
Ref: kubevirt@0c086a0

Signed-off-by: machadovilaca <machadovilaca@gmail.com>
@machadovilaca
Copy link
Member Author

@machadovilaca I think pull-kubevirt-e2e-k8s-1.29-sig-compute is failing because of the PR changes. Seems related to kubevirt_vmi_vcpu_seconds_total metric.

all passing now

@machadovilaca machadovilaca mentioned this pull request Apr 29, 2024
Open
@assafad
Copy link
Contributor

assafad commented Apr 30, 2024

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2024
sradco
sradco reviewed May 6, 2024
View reviewed changes
docs/metrics.md

If you feel that the new metric doesn't follow these rules, please change `doc-generator` with your needs.
All metrics documented here are auto-generated and reflect exactly what is being
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@machadovilaca Why not keep the note about make generate ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personal opinion, I like this wording better, and tbh if a developer didn't regenerate this document, he also did not read this section at the end of the file. We also already have the CI validating the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sradco sradco sradco approved these changes

@fossedihelm fossedihelm Awaiting requested review from fossedihelm

@rthallisey rthallisey Awaiting requested review from rthallisey

@xpivarc xpivarc Awaiting requested review from xpivarc

Assignees

@sradco sradco

@assafad assafad

Labels
area/monitoring dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/build-change Categorizes PRs as related to changing build files of virt-* components lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/buildsystem Denotes an issue or PR that relates to changes in the build system. sig/observability Denotes an issue or PR that relates to observability. sig/scale size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@machadovilaca @kubevirt-bot @assafad @sradco