Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated client: embed generated methods into VMIM interface #11639

Merged
merged 8 commits into from Apr 11, 2024
Merged

Generated client: embed generated methods into VMIM interface #11639

merged 8 commits into from Apr 11, 2024

Commits on Apr 10, 2024

  1. feat: use common params for vmim.Get 

    vmim.Get method does not allow to pass the context and uses the pointer to GetOptions.
In order to align the custom method signature with the generated one
switch using the GetOptions instead of the pointer one and introduce the context.
This effort, once all the common methods' signatures are aligned with
the generated ones, will converge in the deletion of the
custom methods' implementations, embedding the generated interface.

Signed-off-by: fossedihelm <ffossemo@redhat.com>
    @fossedihelm
    fossedihelm committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    fab947f View commit details
    Browse the repository at this point in the history

  2. feat: use common params for vmim.List 

    vmim.List method does not allow to pass the context and uses the pointer to ListOptions.
In order to align the custom method signature with the generated one
switch using the ListOptions instead of the pointer one and introduce the context.
This effort, once all the common methods' signatures are aligned with
the generated ones, will converge in the deletion of the
custom methods' implementations, embedding the generated interface.

Signed-off-by: fossedihelm <ffossemo@redhat.com>
    @fossedihelm
    fossedihelm committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    25b553c View commit details
    Browse the repository at this point in the history

  3. feat: use common params for vmim.Create 

    vmim.Create method does not allow to pass the context and uses the pointer to CreateOptions.
In order to align the custom method signature with the generated one
switch using the CreateOptions instead of the pointer one and introduce the context.
This effort, once all the common methods' signatures are aligned with
the generated ones, will converge in the deletion of the
custom methods' implementations, embedding the generated interface.

Signed-off-by: fossedihelm <ffossemo@redhat.com>
    @fossedihelm
    fossedihelm committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    c6b79cb View commit details
    Browse the repository at this point in the history

  4. feat: use common params for vmim.Update 

    vmim.Update method does not allow to pass the context and UpdateOptions.
In order to align the custom method signature with the generated one introduce
the context and the UpdateOptions.
This effort, once all the common methods' signatures are aligned with
the generated ones, will converge in the deletion of the
custom methods' implementations, embedding the generated interface.

Signed-off-by: fossedihelm <ffossemo@redhat.com>
    @fossedihelm
    fossedihelm committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    1696db4 View commit details
    Browse the repository at this point in the history

  5. feat: use common params for vmim.Delete 

    vmim.Delete method does not allow to pass the context and uses the pointer to DeleteOptions.
In order to align the custom method signature with the generated one
switch using the DeleteOptions instead of the pointer one and introduce the context.
This effort, once all the common methods' signatures are aligned with
the generated ones, will converge in the deletion of the
custom methods' implementations, embedding the generated interface.

Signed-off-by: fossedihelm <ffossemo@redhat.com>
    @fossedihelm
    fossedihelm committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    b1770cd View commit details
    Browse the repository at this point in the history

  6. feat: use common params for vmim.Patch 

    vmim.Patch and vmim.PatchStatus methods do not allow to pass the context and PatchOptions.
In order to align the custom methods signature with the generated ones introduce
the context and the PatchOptions.
This effort, once all the common methods' signatures are aligned with
the generated ones, will converge in the deletion of the
custom methods' implementations, embedding the generated interface.

Signed-off-by: fossedihelm <ffossemo@redhat.com>
    @fossedihelm
    fossedihelm committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    781fdf7 View commit details
    Browse the repository at this point in the history

  7. feat: use common params for vmim.UpdateStatus 

    vmim.UpdateStatus method does not allow to pass the context and UpdateOptions.
In order to align the custom method signature with the generated one introduce
the context and the UpdateOptions.
This effort, once all the common methods' signatures are aligned with
the generated ones, will converge in the deletion of the
custom methods' implementations, embedding the generated interface.

Also, removed duplicate metav1 import with different names.

Signed-off-by: fossedihelm <ffossemo@redhat.com>
    @fossedihelm
    fossedihelm committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    c8c04ee View commit details
    Browse the repository at this point in the history

  8. feat: embed generated client for VMIM interface 

    The embed will provide us new methods (`DeleteCollection` and `Watch`).

Signed-off-by: fossedihelm <ffossemo@redhat.com>
    @fossedihelm
    fossedihelm committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    108d5de View commit details
    Browse the repository at this point in the history