Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.2] Collect VMI OS info from the Guest agent #11720

Merged
merged 1 commit into from Apr 20, 2024
Merged

[release-1.2] Collect VMI OS info from the Guest agent #11720

merged 1 commit into from Apr 20, 2024

Conversation

assafad
Copy link
Contributor

@assafad assafad commented Apr 17, 2024

This is a manual cherry-pick of #11283.

Release note

Collect VMI OS info from the Guest agent as `kubevirt_vmi_phase_count` metric labels

@assafad
Collect VMI OS info from the Guest agent
380da6e 
Signed-off-by: assafad <aadmi@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L labels Apr 17, 2024
@assafad assafad changed the title Collect VMI OS info from the Guest agent [release-1.2] Collect VMI OS info from the Guest agent Apr 17, 2024
@kubevirt-bot kubevirt-bot added area/monitoring sig/buildsystem Denotes an issue or PR that relates to changes in the build system. labels Apr 17, 2024
@assafad
Copy link
Contributor Author

assafad commented Apr 17, 2024

/cc @enp0s3, @machadovilaca

enp0s3
enp0s3 reviewed Apr 17, 2024
View reviewed changes
Copy link
Contributor

@enp0s3 enp0s3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
waiting for monitoring lane

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enp0s3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2024
@assafad
Copy link
Contributor Author

assafad commented Apr 17, 2024

/retest-required

1 similar comment
@assafad
Copy link
Contributor Author

assafad commented Apr 18, 2024

/retest-required

@machadovilaca
Copy link
Member

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Apr 19, 2024 •
edited

@assafad: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-goveralls 380da6e link false /test pull-kubevirt-goveralls-1.2
pull-kubevirt-e2e-arm64 380da6e link false /test pull-kubevirt-e2e-arm64-1.2
pull-kubevirt-check-tests-for-flakes 380da6e link false /test pull-kubevirt-check-tests-for-flakes-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot kubevirt-bot merged commit 531ec6d into kubevirt:release-1.2 Apr 20, 2024
32 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enp0s3 enp0s3 enp0s3 left review comments

@fossedihelm fossedihelm Awaiting requested review from fossedihelm

@kbidarkar kbidarkar Awaiting requested review from kbidarkar

Assignees

@machadovilaca machadovilaca

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/monitoring dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/buildsystem Denotes an issue or PR that relates to changes in the build system. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@assafad @kubevirt-bot @machadovilaca @kubevirt-commenter-bot @enp0s3