e2e,sysprep: Fix VMI namespace for sysprep test #11738
Conversation
kubevirt-bot
added
the
release-note-none
kubevirt-bot
added
the
dco-signoff: yes
|
/cc @dhiller |
tests/sysprep_test.go
Outdated
| cm := libconfigmap.New("sysprepautounattend", map[string]string{"Autounattend.xml": answerFileWithKey, "Unattend.xml": answerFileWithKey}) | ||
| cm, err := virtClient.CoreV1().ConfigMaps(windowsVMI.Namespace).Create(context.Background(), cm, metav1.CreateOptions{}) | ||
| cm, err := virtClient.CoreV1().ConfigMaps(windowsVMI.ObjectMeta.Namespace).Create(context.Background(), cm, metav1.CreateOptions{}) |
There was a problem hiding this comment.
Isn't testsuite.GetTestNamespace(windowsVMI) enough?
There was a problem hiding this comment.
Yes there was no need for the update to the configmap - i've removed that and tested it here - https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/periodic-kubevirt-e2e-sysprep/1780860358886428672
Signed-off-by: Brian Carey <bcarey@redhat.com>
brianmcarey
force-pushed
the
vmi-sysprep-fix
branch
from
8b3a810
to
4df23de
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhiller The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
Required labels detected, running phase 2 presubmits: |
|
/retest-required |
|
@brianmcarey: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required |
1 similar comment
|
/retest-required |
What this PR does
Currently the
periodic-kubevirt-e2e-syspreptest lane is failing trying to create a VMI without a namespace[1].Update the test to include the namespace.
Successful run with this change: https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/periodic-kubevirt-e2e-sysprep/1780626069154435072
[1] https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/periodic-kubevirt-e2e-sysprep/1780385919203807232
Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note