Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't timeout assertion #11793

Closed
wants to merge 1 commit into from
Closed

Don't timeout assertion #11793

wants to merge 1 commit into from

Conversation

xpivarc
Copy link
Member

@xpivarc xpivarc commented Apr 25, 2024

What this PR does

It is most likely that assertion doesn't
have enough time to finish within 30 seconds.

Let's see if this really needs to be wrapped
in Eventually.

Fixes #

Special notes for your reviewer

Release note

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 25, 2024
@brianmcarey
Copy link
Member

/test pull-kubevirt-e2e-k8s-1.28-sig-compute

@brianmcarey
Copy link
Member

/test pull-kubevirt-e2e-k8s-1.27-sig-compute

@xpivarc
Copy link
Member Author

xpivarc commented Apr 25, 2024

/test pull-kubevirt-check-tests-for-flakes

@brianmcarey
Copy link
Member

/test pull-kubevirt-check-tests-for-flakes
/test pull-kubevirt-e2e-k8s-1.28-sig-compute
/test pull-kubevirt-e2e-k8s-1.27-sig-compute
/test pull-kubevirt-e2e-k8s-1.29-sig-compute

It is most likely that assertion doesn't
have enough time to finish within 30 seconds.

Let's see if this really needs to be wrapped
in Eventually.

Signed-off-by: Luboslav Pivarc <lpivarc@redhat.com>
@kubevirt-bot
Copy link
Contributor

@xpivarc: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-check-tests-for-flakes 006570e link false /test pull-kubevirt-check-tests-for-flakes
pull-kubevirt-e2e-k8s-1.29-sig-compute 006570e link true /test pull-kubevirt-e2e-k8s-1.29-sig-compute
pull-kubevirt-e2e-k8s-1.30-sig-compute-serial 006570e link true /test pull-kubevirt-e2e-k8s-1.30-sig-compute-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@acardace
Copy link
Member

acardace commented May 9, 2024

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acardace

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2024
@xpivarc
Copy link
Member Author

xpivarc commented May 10, 2024

/close
Alternative: we just check what the cgroups allow.

@kubevirt-bot
Copy link
Contributor

@xpivarc: Closed this PR.

In response to this:

/close
Alternative: we just check what the cgroups allow.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants