test/utils: Remove NotDeleted() and NotDeletedVMs()

[assafad]

What this PR does

• Move NotDeleted() to /libreplicaset (since it's used only by replicaset test), rename it to FilterNotDeletedVMIs() and remove its named returned value.
• Move NotDeletedVMs() to pool_test.go (the only file it's used in), and improve by integrating it within
  notDeletedVMs() function, which was renamed to filterNotDeletedVMIsOwnedByPool().

/sig code-quality

None

[orelmisan]

Thank you for the PR @assafad.

AFAIU, NotDeleted() and NotDeletedVMs() are unrelated.
Could you please split the change to two commits? (one for each function move)

[orelmisan]

Please consider renaming NotDeleted to FilterVMIsNotMarkedForDeletion or something along those lines, in order to better understand the action it performs from its name.

Same for NotDeletedVMs.

Please also consider removing the named return values from their signatures.

[assafad]

orelmisan updated.

[kubevirt-bot]

@assafad: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubevirt-e2e-kind-1.27-vgpu	87d8cc5	link	false	/test pull-kubevirt-e2e-kind-1.27-vgpu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[orelmisan]

Thank you @assafad

[assafad]

@xpivarc Hi, the PR started with 1 commit, then 2 commits, and finally, per @orelmisan's request, I split it to 4 commits.

[xpivarc]

/approve

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xpivarc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• tests/OWNERS [xpivarc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kubevirt-commenter-bot]

Required labels detected, running phase 2 presubmits:
/test pull-kubevirt-e2e-windows2016
/test pull-kubevirt-e2e-kind-sriov
/test pull-kubevirt-e2e-k8s-1.30-ipv6-sig-network
/test pull-kubevirt-e2e-k8s-1.28-sig-network
/test pull-kubevirt-e2e-k8s-1.28-sig-storage
/test pull-kubevirt-e2e-k8s-1.28-sig-compute
/test pull-kubevirt-e2e-k8s-1.28-sig-operator
/test pull-kubevirt-e2e-k8s-1.29-sig-network
/test pull-kubevirt-e2e-k8s-1.29-sig-storage
/test pull-kubevirt-e2e-k8s-1.29-sig-compute
/test pull-kubevirt-e2e-k8s-1.29-sig-operator