Framework for watch/job unittest #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Controller with list watch for Migration jobs 3 Unit tests for watch/Job: Negative: ignore a job that has no label Negative: ignore a job that has label but no successes Positive: if label matches, should see a fetch and an update of the VM
stu-gott
requested changes
Mar 10, 2017
| fieldSelector := fields.Everything() | ||
| labelSelector, err := labels.Parse(kvirtv1.DomainLabel) | ||
| if err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
We probably don't want to panic here. make this function return
(kubeapi.ListOptions, error)
and handle the error higher in the call chain.
Also, we definitely want to log this error.
logger := logging.DefaultLogger()
There was a problem hiding this comment.
I would say panic is fine, since this really never should fail ...
rmohr
approved these changes
Mar 13, 2017
rmohr
added a commit
that referenced
this pull request
Mar 13, 2017
Framework for watch/job unittest
kubevirt-bot
pushed a commit
to kubevirt-bot/kubevirt
that referenced
this pull request
Dec 7, 2021
Signed-off-by: Arik Hadas <ahadas@bamba.tlv.redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Controller with list watch for Migration jobs
3 Unit tests for watch/Job:
Negative: ignore a job that has no label
Negative: ignore a job that has label but no successes
Positive: if label matches, should see a fetch and an update of the VM