Cleanups #1667
Merged
Cleanups #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arik Hadas <ahadas@redhat.com>
Signed-off-by: Arik Hadas <ahadas@redhat.com>
kubevirt-bot
added
release-note-none
rmohr
approved these changes
Nov 2, 2018
| templatePod, err := c.templateService.RenderLaunchManifest(vmi) | ||
| if _, ok := err.(services.PvcNotFoundError); ok { | ||
| return &syncErrorImpl{fmt.Errorf("failed to render launch manifest: %v", err), FailedPvcNotFoundReason} | ||
| } else if err != nil { | ||
| return &syncErrorImpl{fmt.Errorf("failed to render launch manifest: %v", err), FailedCreatePodReason} | ||
| } | ||
|
|
||
| vmiKey := controller.VirtualMachineKey(vmi) | ||
| c.podExpectations.ExpectCreations(vmiKey, 1) |
There was a problem hiding this comment.
That's not only cosmetic, that's also more correct. We don't expect a pod creation if the mentioned PVCs above do not exist yet. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Minor cleanup in controller's vmi.go and vmi_tests.go, e.g., fix typo, moving variables declaration closer to the place they're used, etc.
Release note: