Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add virt-viewer download instructions for Windows #1694

Merged
merged 1 commit into from Nov 28, 2018
Merged

Add virt-viewer download instructions for Windows #1694

merged 1 commit into from Nov 28, 2018

Conversation

qmfrederik
Copy link
Contributor

@qmfrederik qmfrederik commented Nov 13, 2018

What this PR does / why we need it:
Add virt-viewer download instructions for Windows. Took me some searching to figure this out, and thought it was worth documenting.

Which issue(s) this PR fixes

Special notes for your reviewer:

Release note:

NONE

@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically.
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@kubevirt-bot kubevirt-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 13, 2018
Copy link
Member

@rmohr rmohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qmfrederik I guess that vnc access worked for you then without further modifications?

@qmfrederik
Copy link
Contributor Author

@rmohr Yes it did!

@slintes
Copy link
Contributor

slintes commented Nov 13, 2018

great, but I'm afraid this won't work anymore after merge of #1673, because windows seems to be ignored there. Will request to add "remote-viewer" for windows over there.

@fabiand
Copy link
Member

fabiand commented Nov 28, 2018

@slintes I see that #1673 did not get the windows support, correct?

@slintes
Copy link
Contributor

slintes commented Nov 28, 2018

@fabiand yes, tracking it in #1713

@fabiand
Copy link
Member

fabiand commented Nov 28, 2018

Ack, then I think this one is good to go.

@fabiand fabiand merged commit d8d5dca into kubevirt:master Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants