Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Openshift 3.11 and k8s 1.12.2 with multus providers. #1726

Merged
merged 1 commit into from
Dec 11, 2018
Merged

Added Openshift 3.11 and k8s 1.12.2 with multus providers. #1726

merged 1 commit into from
Dec 11, 2018

Conversation

SchSeba
Copy link
Contributor

@SchSeba SchSeba commented Nov 19, 2018 •
edited
Loading

What this PR does / why we need it:
Added Openshift 3.11 and k8s 1.12.2 with multus providers.

Release note:

none

This change is Reviewable

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M labels Nov 19, 2018
@cynepco3hahue
Copy link

cynepco3hahue commented Nov 19, 2018 •
edited
Loading

@SchSeba Can you please add relevant kubevirtci PR under the description?

@SchSeba
Copy link
Contributor Author

SchSeba commented Nov 19, 2018

@cynepco3hahue Done
kubevirt/kubevirtci#52

@SchSeba SchSeba force-pushed the multus-provider-3.11-and-1.12.2 branch from 0ca54ec to 5fb3f85 Compare November 19, 2018 15:07
@SchSeba
Copy link
Contributor Author

SchSeba commented Nov 19, 2018

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2018
@SchSeba SchSeba force-pushed the multus-provider-3.11-and-1.12.2 branch from 5fb3f85 to 97ad8d9 Compare November 19, 2018 21:21
@SchSeba
Copy link
Contributor Author

SchSeba commented Nov 19, 2018

/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2018
@SchSeba
Copy link
Contributor Author

SchSeba commented Nov 20, 2018

For reference https://jenkins.ovirt.org/job/kubevirt_kubevirt_standard-check-pr/2554//artifact/check-patch.k8s-multus-1.12.2-release.el7.x86_64/mock_logs/script/stdout_stderr.log

@SchSeba SchSeba force-pushed the multus-provider-3.11-and-1.12.2 branch from 97ad8d9 to 94a17af Compare November 20, 2018 08:58
@SchSeba
Copy link
Contributor Author

SchSeba commented Nov 20, 2018

ci test please

@rmohr
Copy link
Member

rmohr commented Nov 21, 2018

@SchSeba the openshift multus run complains about a non-existent shasum. The k8s run looks pretty good.

rmohr
rmohr reviewed Nov 21, 2018
View reviewed changes
cluster/os-3.11.0-multus/provider.sh Outdated

source cluster/os-3.11.0/provider.sh

image="os-3.11.0-multus@sha256:b7354263a7828cb13ae103f84c9d7c9d8def8f3edf6014a5e8e330724588afae"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be that this should be os-3.11.0-multus@sha256:dfeaa7c1f7c264f953e44c93b50bb76c9bb58b0df8bb94dcaa108db254f87eb3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know but this is weird can you please try to run docker pull locally and tell me if it works for you? because it works for me.
docker pull kubevirtci/os-3.11.0-multus@sha256:b7354263a7828cb13ae103f84c9d7c9d8def8f3edf6014a5e8e330724588afae

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes works for me. Maybe it was a transient issue? Which shasum is now the correct one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the last one I pushed yesterday.
b7354263a7828cb13ae103f84c9d7c9d8def8f3edf6014a5e8e330724588afae

I will try to run the tests again

@SchSeba
Copy link
Contributor Author

SchSeba commented Nov 21, 2018

ci test please

@SchSeba
Copy link
Contributor Author

SchSeba commented Nov 22, 2018

@gbenhaim Can I get some help with the openshift 3.11 multus error (fail to pull from docker hub)

@SchSeba
Copy link
Contributor Author

SchSeba commented Nov 26, 2018

ci test please

@SchSeba SchSeba force-pushed the multus-provider-3.11-and-1.12.2 branch 2 times, most recently from 471cbe9 to 919fa62 Compare November 27, 2018 14:08
@SchSeba
Copy link
Contributor Author

SchSeba commented Nov 27, 2018

@rmohr can you please take a look

openshift https://jenkins.ovirt.org/job/kubevirt_kubevirt_standard-check-pr/2637//artifact/check-patch.openshift-3.11-multus-release.el7.x86_64/mock_logs/script/stdout_stderr.log

kubernetes https://jenkins.ovirt.org/job/kubevirt_kubevirt_standard-check-pr/2637//artifact/check-patch.k8s-multus-1.12.2-release.el7.x86_64/mock_logs/script/stdout_stderr.log

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 4, 2018
@SchSeba SchSeba mentioned this pull request Dec 4, 2018
Merged
@SchSeba SchSeba force-pushed the multus-provider-3.11-and-1.12.2 branch from 919fa62 to 0cb968f Compare December 9, 2018 16:41
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 9, 2018
@SchSeba SchSeba force-pushed the multus-provider-3.11-and-1.12.2 branch from 0cb968f to fc0ed11 Compare December 10, 2018 08:31
@SchSeba SchSeba force-pushed the multus-provider-3.11-and-1.12.2 branch from fc0ed11 to 6027689 Compare December 10, 2018 09:28
@SchSeba
Copy link
Contributor Author

SchSeba commented Dec 10, 2018

for reference https://jenkins.ovirt.org/job/kubevirt_kubevirt_standard-check-pr/2844//artifact/check-patch.openshift-3.11-multus-release.el7.x86_64/mock_logs/script/stdout_stderr.log

@SchSeba
Copy link
Contributor Author

SchSeba commented Dec 10, 2018

ci test please

@SchSeba SchSeba mentioned this pull request Dec 10, 2018
Merged
@SchSeba
Copy link
Contributor Author

SchSeba commented Dec 10, 2018

ci test please

@SchSeba
Copy link
Contributor Author

SchSeba commented Dec 11, 2018

@cynepco3hahue I think this is ready to go.

@rmohr
Copy link
Member

rmohr commented Dec 11, 2018

@SchSeba I see in http://jenkins.ovirt.org/job/kubevirt_kubevirt_standard-check-pr/2859//artifact/check-patch.k8s-multus-1.12.2-release.el7.x86_64/mock_logs/script/stdout_stderr.log

S [SKIPPING] in Spec Setup (BeforeEach) [0.003 seconds]
Multus Networking
/root/go/src/kubevirt.io/kubevirt/tests/vmi_multus_test.go:48
  VirtualMachineInstance with sriov plugin interface [BeforeEach]
  /root/go/src/kubevirt.io/kubevirt/tests/vmi_multus_test.go:210
    should create a virtual machine with sriov interface
    /root/go/src/kubevirt.io/kubevirt/tests/vmi_multus_test.go:218

    Skip multus tests that required multus cni plugin

    /root/go/src/kubevirt.io/kubevirt/tests/utils.go:1966

Is that the correct behaviour?

@rmohr
Copy link
Member

rmohr commented Dec 11, 2018

Looks good to me, if the behaviour mentioned above is correct.

@cynepco3hahue
Copy link

https://jenkins.ovirt.org/job/kubevirt_kubevirt_standard-check-pr/2859//artifact/check-patch.k8s-multus-1.12.2-release.el7.x86_64/mock_logs/script/stdout_stderr.log failed to finish the run, will re-run CI.

@cynepco3hahue
Copy link

ci test please

@rmohr
Copy link
Member

rmohr commented Dec 11, 2018

@cynepco3hahue that's the pci address test. It fails randomly on lanes. We should fix that test asap.

@cynepco3hahue
Copy link

@rmohr strange first time I saw only part of the log

@cynepco3hahue cynepco3hahue merged commit 28430a5 into kubevirt:master Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmohr rmohr rmohr left review comments

@phoracek phoracek phoracek approved these changes

@cynepco3hahue cynepco3hahue cynepco3hahue approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SchSeba @cynepco3hahue @rmohr @phoracek @kubevirt-bot