Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use newer gocli which is more robust against pull errors #2022

Merged
merged 1 commit into from Feb 14, 2019

Conversation

rmohr
Copy link
Member

@rmohr rmohr commented Feb 13, 2019

What this PR does / why we need it:

In case pulling images fails during cluster-up, gocli will retry four
times per image before giving up. That should help against flakes when
starting the cluster.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Example symptomes which this PR can fix:

$ make cluster-up
./cluster/up.sh
Downloading .............
Error: No such image: registry:2

Release note:

NONE

@kubevirt-bot kubevirt-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 13, 2019
In case pulling images fails during cluster-up, gocli will retry four
times per image before giving up. That should help against flakes when
starting the cluster.
@cynepco3hahue cynepco3hahue merged commit b89be83 into kubevirt:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants