Fix some migration bugs #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rmohr
commented
May 9, 2017
•
rmohr
commented
- A label was not set after successful migration, which left the VM visible after the migration to the old virt-handler
|
/cc @mojaves FYI regarding the signal forwarding from libvirt |
|
CCing the right persona, @fromanirh |
Whenever we update Status.nodeName we also have to update the corresponding label, since fieldSelectors are not supported yet for TPRs.
To ensure, to catch bugs where only the first migration succeeds, migrate a VM three times in a row.
Functional tests fetch logs from this pod. If an old pod is stuck interminating, we check for the deletion time stamp to select the active pod. This is a workaround for a deployment bug in kubernetes.
|
LGTM |
stu-gott
approved these changes
May 12, 2017
kubevirt-bot
pushed a commit
to kubevirt-bot/kubevirt
that referenced
this pull request
Nov 6, 2020
mzzgaopeng
pushed a commit
to mzzgaopeng/kubevirt
that referenced
this pull request
Mar 8, 2021
The current vendor of sys/unix is really old, and doesn't work on arm64 and ppc64le Updating to the latest version might also fix other issues ref kubevirt#209
mzzgaopeng
pushed a commit
to mzzgaopeng/kubevirt
that referenced
this pull request
Mar 8, 2021
… architectures This makes it possible to cross-compile cni like so: $ GOARCH=arm ./build $ GOARCH=arm64 ./build $ GOARCH=ppc64le ./build ref kubevirt#209
mzzgaopeng
pushed a commit
to mzzgaopeng/kubevirt
that referenced
this pull request
Mar 8, 2021
Cross-compile cni for arm, arm64 and ppc64le with go1.6 only Allow go tip to fail Set fast_finish to true, which means travis will instantly return build failure when any of the required builds fail ref kubevirt#209
mzzgaopeng
pushed a commit
to mzzgaopeng/kubevirt
that referenced
this pull request
Mar 8, 2021
Modify the releasing script to cross-compile for the new architectures, but also keep backwards-compability ref kubevirt#209
mzzgaopeng
pushed a commit
to mzzgaopeng/kubevirt
that referenced
this pull request
Mar 8, 2021
Updated README to include bandwidth plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.