Remove inject framework #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were barely using it. The framework requires fully creating objects before wiring up dependencies, which is a violation of OO concepts. An object should be complelely valid after the constructor returns.
|
Before we do better Dependency Injection, lets get out interfaces right. The inject framework makes some a practice a requirement for the object composition: the requirement that you fully create objects with unfulfilled dependencies. |
kubevirt-bot
pushed a commit
to kubevirt-bot/kubevirt
that referenced
this pull request
Dec 7, 2021
* k8s: Do not remove nm Signed-off-by: Quique Llorente <ellorent@redhat.com> * Update k8s-1.17.1 hash Signed-off-by: Quique Llorente <ellorent@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were barely using it.
The framework requires fully creating objects before wiring
up dependencies, which is a violation of OO concepts. An
object should be complelely valid after the constructor returns.