Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SELinux functional tests #3092

Merged
merged 1 commit into from Feb 26, 2020
Merged

Fix SELinux functional tests #3092

merged 1 commit into from Feb 26, 2020

Conversation

stu-gott
Copy link
Member

Some tests assumed that selinuxLauncherType would not be set.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1805204

Release note:

None

@stu-gott
Fix SELinux functional tests
91619bb 
Some tests assumed that selinuxLauncherType would not be set.

Signed-off-by: Stu Gott <sgott@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L labels Feb 20, 2020
@stu-gott
Copy link
Member Author

/cc @rmohr

@openshift-ci-robot
Copy link
Collaborator

@stu-gott: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e 91619bb link /test e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stu-gott
Copy link
Member Author

/retest

1 similar comment
@vladikr
Copy link
Member

vladikr commented Feb 26, 2020

/retest

vladikr
vladikr reviewed Feb 26, 2020
View reviewed changes
Copy link
Member

@vladikr vladikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2020
@vladikr
Copy link
Member

vladikr commented Feb 26, 2020

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vladikr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2020
@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Feb 26, 2020 •
edited

@stu-gott: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubevirt-e2e-k8s-1.15-ceph 91619bb link /test pull-kubevirt-e2e-k8s-1.15-ceph
pull-kubevirt-e2e-k8s-1.16 91619bb link /test pull-kubevirt-e2e-k8s-1.16
pull-kubevirt-e2e-k8s-1.14 91619bb link /test pull-kubevirt-e2e-k8s-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@stu-gott
Copy link
Member Author

/override pull-kubevirt-e2e-k8s-1.15.1-ceph

@kubevirt-bot
Copy link
Contributor

@stu-gott: Overrode contexts on behalf of stu-gott: pull-kubevirt-e2e-k8s-1.15.1-ceph

In response to this:

/override pull-kubevirt-e2e-k8s-1.15.1-ceph

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit 8d31230 into kubevirt:master Feb 26, 2020
@stu-gott
Copy link
Member Author

stu-gott commented Mar 2, 2020

/cherry-pick release-0.26

@kubevirt-bot kubevirt-bot mentioned this pull request Mar 2, 2020
Merged
@kubevirt-bot
Copy link
Contributor

@stu-gott: new pull request created: #3121

In response to this:

/cherry-pick release-0.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladikr vladikr vladikr left review comments

@ILpinto ILpinto Awaiting requested review from ILpinto

@jerry7z jerry7z Awaiting requested review from jerry7z

@rmohr rmohr Awaiting requested review from rmohr

Assignees

@vladikr vladikr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stu-gott @openshift-ci-robot @vladikr @kubevirt-bot @kubevirt-commenter-bot