Fix relabeling rules #3146
Fix relabeling rules #3146
Conversation
kubevirt-bot
added
dco-signoff: yes
The `labeldrop` action requires only `regex` matcher to be set. Also, added a test case to ensure that our metrics are not being relabeled. Signed-off-by: Daniel Belenky <dbelenky@redhat.com>
danielBelenky
force-pushed
the
fix-relabeling-rules
branch
from
1593ca6
to
8f5b1bc
Compare
|
|
||
| // We need a token from a service account that can view all namespaces in the cluster | ||
| By("extracting virt-operator sa token") | ||
| token, _, err := tests.ExecuteCommandOnPodV2(virtClient, |
There was a problem hiding this comment.
This looks very sneaky. Isn't there another solution? I.e. can't we just create a test token or something?
There was a problem hiding this comment.
we can, but it complicates things.. it will require to create a service account just for the test, extract it's token and then tear it down after the test if over... at first, I implemented it that way but then I thought that it will be better to just reuse the operator service account just like we're using the handler pod to query to metrics.
| "-k", | ||
| fmt.Sprintf("https://%s:%d/api/v1/query", promIP, promPort), | ||
| "-H", | ||
| fmt.Sprintf("Authorization: Bearer %s", token), |
There was a problem hiding this comment.
you don't actually have to extract the bearer token from the pod do you? Because the right token is already in the pod you're executing this command within.
What would happen if you replaced this line with something line the following instead?
"Authorization: Bearer $(cat /var/run/secrets/kubernetes.io/serviceaccount/token)"
There was a problem hiding this comment.
It is not that straight forward as it seems at first... I've tried this approach before and the problem is that the execution of a sub-shell does not seem to work as I expected after processed by exec.
Even if I can get it to work, I think that it will have a negative impact on the readability of this test.
No. This PR is part of the fix for https://bugzilla.redhat.com/show_bug.cgi?id=1805044 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidvossel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
approved
|
/retest |
The
labeldropaction requires onlyregexmatcher to be set.Signed-off-by: Daniel Belenky dbelenky@redhat.com