Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix English typo #318

Merged
merged 1 commit into from
Jul 19, 2017
Merged

Conversation

dankenigsberg
Copy link
Member

No description provided.

@dankenigsberg
Copy link
Member Author

@fabiand, I need to re-read the readme; but it seems that it does not explain why it is a good idea to run VMs via k8s.

@fabiand
Copy link
Member

fabiand commented Jul 16, 2017

Please see
https://github.com/kubevirt/kubevirt.github.io/blob/master/about.md
and
https://github.com/kubevirt/kubevirt.github.io/blob/master/index.md

I think in addition it is a good idea to keep the mission and motivation in this repo, @berrange

@berrange
Copy link
Contributor

Needs a commit signoff added.

I don't thin we need to duplicate all that info in the README file too - at most just point people to the website from the README

In post Shakespearian English, it's != its

Signed-off-by: Dan Kenigsberg <danken@redhat.com>
@fabiand
Copy link
Member

fabiand commented Jul 19, 2017

Thanks!

@fabiand fabiand merged commit a4d9d36 into kubevirt:master Jul 19, 2017
@dankenigsberg dankenigsberg deleted the dankenigsberg-fixtypo branch July 19, 2017 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants