README: fix another English typo #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: danken@redhat.com
kubevirt-bot
pushed a commit
to kubevirt-bot/kubevirt
that referenced
this pull request
Nov 6, 2020
kubevirt-bot
pushed a commit
to kubevirt-bot/kubevirt
that referenced
this pull request
Dec 7, 2021
* explicitly set SHELL of sriov-operator makefile to bash We can't pass the SHELL settings to a makefile as a variable. Instead, we need to set it as an argument of make. With this change, the SR-IOV lane should work again. Signed-off-by: Petr Horacek <phoracek@redhat.com> * Move policy creation after configuration of webhook With the current code, we try to apply an SriovNodeNetworkPolicy before configuring webhook's secrets. This patch fixes the order. Signed-off-by: Petr Horacek <phoracek@redhat.com> * kind-sriov: make sure it is used only with two nodes The script is only able to move SR-IOV device to the first worker node. Make sure it is clear to users by returning an error if started without 2 nodes. Signed-off-by: Petr Horacek <phoracek@redhat.com> * remove sriov-1.14 lane It does not work and we don't intend to fix it. It uses old Kubernetes, old sriov-operator. Signed-off-by: Petr Horacek <phoracek@redhat.com> * worker nodes are already able It is already done in the base config. Signed-off-by: Petr Horacek <phoracek@redhat.com> * kind-sriov: wait 60 seconds for certificate changes 30 was not enough in some cases. Signed-off-by: Petr Horacek <phoracek@redhat.com> * print NICs info in logs Signed-off-by: Petr Horacek <phoracek@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: danken@redhat.com