Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Create basic RBAC permissions for KubeVirt #322

Closed
wants to merge 2 commits into from

Conversation

rmohr
Copy link
Member

@rmohr rmohr commented Jul 17, 2017

Make sure that KubeVirt can run on Kubernetes instances where RBAC is
enabled. Further give the haproxy admin rights right now, to allow it to
forward all calls to the apiserver.

This does not at all provide a more secure way to run KubeVirt. It's
only purpose at this stage is to allow friction-less deployments on
RBAC enabled Kubernetes clusters.

The depolyment can be properly secured, as soon as we have movedm from
our haproxy approach to the Aggregated API Server.

Fixes #299, #62 and does some initial work for #301.

Signed-off-by: Roman Mohr rmohr@redhat.com

@rmohr
Copy link
Member Author

rmohr commented Jul 17, 2017

/cc @admiyo @fabiand FYI

Make sure that KubeVirt can run on Kubernetes instances where RBAC is
enabled. Further give the haproxy admin rights right now, to allow it to
forward all calls to the apiserver.

This does not at all provide a more secure way to run KubeVirt. It's
only purpose at this stage, is to allow friction less deployments on
RBAC enabled Kubernetes clusters.

The depolyment can be properly secured, as soon as we have movedm from
our haproxy approach to the Aggregated API Server.

Signed-off-by: Roman Mohr <rmohr@redhat.com>
With the permission assignment moved to a manifest, it is no longer
necessary to give the default user admin rights in the Vagrant
environment.

Signed-off-by: Roman Mohr <rmohr@redhat.com>
@rmohr rmohr requested review from fabiand and admiyo July 17, 2017 17:06
@rmohr rmohr changed the title [WIP] Create basic RBAC permissions for KubeVirt Create basic RBAC permissions for KubeVirt Jul 17, 2017
Copy link
Member

@fabiand fabiand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@rmohr
Copy link
Member Author

rmohr commented Jul 18, 2017

Something is still not completely right. Don't merge yet!

@rmohr rmohr changed the title Create basic RBAC permissions for KubeVirt [DO NOT MERGE] Create basic RBAC permissions for KubeVirt Jul 18, 2017
@davidvossel
Copy link
Member

any more word on this?

I think it's really important that we start working with RBAC now for each of our components.

With RBAC limited to exactly what each component consumes, it means we have to be explicit about any new capabilities that are being added to a component. This will make it obvious when we try to give a component access to cluster capabilities it really shouldn't have access to.

@rmohr
Copy link
Member Author

rmohr commented Sep 1, 2017

Ok, so the latest state on this is, that everything works when starting VMs, ... by hand. However functional tests currently don't start because of a permission error. Will look into it as soon as I can. But someone else can pick it up too. Also @admiyo confirmed that he could practically unchanged use this PR on OpenShift during his investigations.

@fabiand
Copy link
Member

fabiand commented Sep 6, 2017

@rmohr if you don#t mind then I'd update this PR

@rmohr
Copy link
Member Author

rmohr commented Sep 6, 2017

Please go ahead. That would be great.

@fabiand fabiand mentioned this pull request Sep 6, 2017
@fabiand
Copy link
Member

fabiand commented Sep 6, 2017

Obsoleted by #418.

Closing this one.

@fabiand fabiand closed this Sep 6, 2017
mzzgaopeng pushed a commit to mzzgaopeng/kubevirt that referenced this pull request Mar 8, 2021
…cni-stateDir

Allow flannel CNI plugin stateDir to be configurable
mzzgaopeng pushed a commit to mzzgaopeng/kubevirt that referenced this pull request Mar 8, 2021
Update github.com/safchain/ethtool to fix the compilation
error on 386. Also added 386 to the tarvis yaml.

Fixes kubevirt#322

Signed-off-by: Moshe Levi <moshele@mellanox.com>
kubevirt-bot pushed a commit to kubevirt-bot/kubevirt that referenced this pull request Dec 7, 2021
In order for kind provider to work with make cluster-sync, we need to add
registry mirrors.

Signed-off-by: Petr Horacek <phoracek@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants