Flatten vendor folder #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using "glide install" without the "--strip-vendor" flag, so the vendor directory wasn't actually flattened. Signed-off-by: Stu Gott <sgott@redhat.com>
rmohr
approved these changes
Jul 17, 2017
kubevirt-bot
pushed a commit
to kubevirt-bot/kubevirt
that referenced
this pull request
Dec 7, 2021
Kind default StorageClass is named 'standard', while kubevirt
func tests assume it to be called 'local' - as is for all the
other providers.
To enable the kind-k8s-1.17-ipv6 provider to work out of the box,
the `local-volume-provisioner` daemonset must be deployed. It will
take care of:
- create the 'local' storage class
- discover all mount points in its configuration path (via config
map) and expose those mount points as PersistentVolumes.
For more information, check the local static provisioner repo,
located at [0].
This will enable the functional_tests labeled as 'PVC' to be
executed.
[0] - https://github.com/kubernetes-sigs/sig-storage-local-static-provisioner
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using "glide install" without the "--strip-vendor" flag, so
the vendor directory wasn't actually flattened.
Signed-off-by: Stu Gott sgott@redhat.com