Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert images to use Fedora #324

Merged
merged 3 commits into from
Jul 19, 2017
Merged

Convert images to use Fedora #324

merged 3 commits into from
Jul 19, 2017

Conversation

berrange
Copy link
Contributor

No description provided.

The intention is that Docker images always depend on the latest
released Fedora version.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Use 'set -e' to ensure the docker image build process will
abort if a Dockerfile fails to be processed. This exposed
fact that we tried to build an image for cmd/virtctl which
has no Dockerfile. It also exposed a misplace "shift"
call in the script.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Mark the docker image maintainer as being the project as a
whole rather than an individual person.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Copy link
Member

@fabiand fabiand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@fabiand fabiand requested a review from rmohr July 17, 2017 18:19
@fabiand
Copy link
Member

fabiand commented Jul 19, 2017

@fabiand fabiand merged commit 28374e4 into kubevirt:master Jul 19, 2017
@berrange berrange deleted the disto branch July 20, 2017 12:51
mzzgaopeng pushed a commit to mzzgaopeng/kubevirt that referenced this pull request Mar 8, 2021
mzzgaopeng pushed a commit to mzzgaopeng/kubevirt that referenced this pull request Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants